Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1879453003: Move SVGTextMetricsCalculator to LayoutSVGInlineText.cpp (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SVGTextMetricsCalculator to LayoutSVGInlineText.cpp Mostly plain code move, with some fixups in the (now folded) updateMetricsList method. Also removes the non-const getter for the metrics list. BUG=594058 Committed: https://crrev.com/72c89f9d3b6d02768bd09d2547c05226eefb5e8c Cr-Commit-Position: refs/heads/master@{#386630}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
fs
4 years, 8 months ago (2016-04-11 11:55:50 UTC) #3
pdr.
On 2016/04/11 at 11:55:50, fs wrote: > LGTM
4 years, 8 months ago (2016-04-12 03:43:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879453003/1
4 years, 8 months ago (2016-04-12 07:56:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 08:55:57 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:57:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72c89f9d3b6d02768bd09d2547c05226eefb5e8c
Cr-Commit-Position: refs/heads/master@{#386630}

Powered by Google App Engine
This is Rietveld 408576698