Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1880273002: [DevTools] Create last agents on attach, modify InspectorDatabaseAgent to support it. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
michaeln, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, lushnikov+blink_chromium.org, haraken, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Create last agents on attach, modify InspectorDatabaseAgent to support it. We now ask DatabaseTracker about all open databases when creating the agent. BUG=590878 TEST=http/tests/inspector-enabled/database-open.html Committed: https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635 Cr-Commit-Position: refs/heads/master@{#387496}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Patch Set 3 : two databases in the test #

Messages

Total messages: 18 (7 generated)
dgozman
Could you please take a look? michaeln@ - at modules/webdatabase. pfeldman@ - at web. Thanks, ...
4 years, 8 months ago (2016-04-12 21:01:41 UTC) #2
michaeln
https://codereview.chromium.org/1880273002/diff/1/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h (right): https://codereview.chromium.org/1880273002/diff/1/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h#newcode68 third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h:68: void registerAllDatabasesInInspector(InspectorDatabaseAgent*); It'd be nice to not have a ...
4 years, 8 months ago (2016-04-13 22:18:18 UTC) #3
dgozman
https://codereview.chromium.org/1880273002/diff/1/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h (right): https://codereview.chromium.org/1880273002/diff/1/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h#newcode68 third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h:68: void registerAllDatabasesInInspector(InspectorDatabaseAgent*); On 2016/04/13 22:18:18, michaeln wrote: > It'd ...
4 years, 8 months ago (2016-04-13 22:26:04 UTC) #4
dgozman
All comments addressed, please take another look.
4 years, 8 months ago (2016-04-14 17:41:45 UTC) #6
michaeln
thnx, modules/webdatabase lgtm
4 years, 8 months ago (2016-04-14 19:42:19 UTC) #7
pfeldman
lgtm
4 years, 8 months ago (2016-04-14 20:27:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880273002/40001
4 years, 8 months ago (2016-04-14 20:36:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/212704)
4 years, 8 months ago (2016-04-14 21:46:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880273002/40001
4 years, 8 months ago (2016-04-14 23:26:18 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-15 00:47:58 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 00:49:39 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/071a0f6f8ea7191da644265ec12df41216c68635
Cr-Commit-Position: refs/heads/master@{#387496}

Powered by Google App Engine
This is Rietveld 408576698