[DevTools] Create last agents on attach, modify InspectorDatabaseAgent to support it.

third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 11 matching lines @@
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "modules/webdatabase/InspectorDatabaseAgent.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
+#include "core/dom/Document.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/VoidCallback.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/page/Page.h"
 #include "modules/webdatabase/Database.h"
 #include "modules/webdatabase/DatabaseClient.h"
+#include "modules/webdatabase/DatabaseTracker.h"
 #include "modules/webdatabase/InspectorDatabaseResource.h"
 #include "modules/webdatabase/SQLError.h"
 #include "modules/webdatabase/SQLResultSet.h"
 #include "modules/webdatabase/SQLResultSetRowList.h"
 #include "modules/webdatabase/SQLStatementCallback.h"
 #include "modules/webdatabase/SQLStatementErrorCallback.h"
 #include "modules/webdatabase/SQLTransaction.h"
 #include "modules/webdatabase/SQLTransactionCallback.h"
 #include "modules/webdatabase/SQLTransactionErrorCallback.h"
 #include "modules/webdatabase/sqlite/SQLValue.h"
@@ skipping 164 matching lines @@
     void handleEvent() override { }
 
 private:
     TransactionSuccessCallback() { }
 };
 
 } // namespace
 
 void InspectorDatabaseAgent::didOpenDatabase(blink::Database* database, const String& domain, const String& name, const String& version)
 {
+    ExecutionContext* context = database->getExecutionContext();
+    if (!context->isDocument())

[michaeln, 2016/04/13 22:18:18]

you could ASSERT(isDocument()) since websql is no longer supported from worker
threads

+        return;
+    if (toDocument(context)->frame()->page() != m_page)

[michaeln, 2016/04/13 22:18:18]

oh, you filter for this page only

+        return;
+
     if (InspectorDatabaseResource* resource = findByFileName(database->fileName())) {
         resource->setDatabase(database);
         return;
     }
 
     InspectorDatabaseResource* resource = InspectorDatabaseResource::create(database, domain, name, version);
     m_resources.set(resource->id(), resource);
     // Resources are only bound while visible.
     if (frontend() && m_enabled)
         resource->bind(frontend());
 }
 
 void InspectorDatabaseAgent::didCommitLoadForLocalFrame(LocalFrame* frame)
 {
     // FIXME(dgozman): adapt this for out-of-process iframes.
     if (frame != m_page->mainFrame())
         return;
 
     m_resources.clear();
 }
 
 InspectorDatabaseAgent::InspectorDatabaseAgent(Page* page)
     : InspectorBaseAgent<InspectorDatabaseAgent, protocol::Frontend::Database>("Database")
     , m_page(page)
     , m_enabled(false)
 {
     DatabaseClient::fromPage(page)->setInspectorAgent(this);
+    DatabaseTracker::tracker().registerAllDatabasesInInspector(this);

[michaeln, 2016/04/13 22:18:18]

From the looks of the didCommitLoadForLocalFrame() method, it seems like the
agent class is scoped to a page. Should this inspector only know the set of
databases open in its page?

[dgozman, 2016/04/13 22:26:04]

That's why I've added filtering to didOpenDatabase. Do you think we'd better
pass Page* to registerAllDatabasesInInspector (or getAllDatabasesForPage)? It
does not really matter for me - some place has to filter them out.

 }
 
 InspectorDatabaseAgent::~InspectorDatabaseAgent()
 {
 }
 
 void InspectorDatabaseAgent::enable(ErrorString*)
 {
     if (m_enabled)
         return;
@@ skipping 76 matching lines @@
 }
 
 DEFINE_TRACE(InspectorDatabaseAgent)
 {
     visitor->trace(m_page);
     visitor->trace(m_resources);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink