third_party/WebKit/Source/web/WebDevToolsAgentImpl.h - Issue 1880273002: [DevTools] Create last agents on attach, modify InspectorDatabaseAgent to support it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Issue 1880273002: [DevTools] Create last agents on attach, modify InspectorDatabaseAgent to support it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: two databases in the test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

index 406919dc4fcd87e8d9bf2bbacd794dd06be2e8d2..0ff75656bf1ce719cdb420269482651af493f618 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

@@ -110,7 +110,7 @@ public:

WebString evaluateInWebInspectorOverlay(const WebString& script) override;

private:

- WebDevToolsAgentImpl(WebLocalFrameImpl*, WebDevToolsAgentClient*, InspectorOverlay*);

+ WebDevToolsAgentImpl(WebLocalFrameImpl*, WebDevToolsAgentClient*, InspectorOverlay*, bool includeViewAgents);

// InspectorTracingAgent::Client implementation.

void enableTracing(const WTF::String& categoryFilter) override;

@@ -164,6 +164,7 @@ private:

OwnPtr<protocol::Frontend> m_inspectorFrontend;

InspectorAgentRegistry m_agents;

bool m_deferredAgentsInitialized;

+ bool m_includeViewAgents;

typedef Vector<std::pair<int, OwnPtr<protocol::Value>>> NotificationQueue;

NotificationQueue m_notificationQueue;