Remove CPDF_Object::GetConstString and overrides

Remove CPDF_Object::GetConstString and overrides

GetConstString() has sharp edges in that when applied to
a CPDF_Number, it must return null whereas GetString() returns
a the stringified number, because of the inability to
control the lifetime of the underlying allocated string.

Deleting this method showed several places where we
actually wanted a *String, not a *StringC, so we were
re-allocating a string we already had.

Committed: https://pdfium.googlesource.com/pdfium/+/822484b5f88d92dbcd567b1c2da38af1e720b56f

[Tom Sepez, 2016-04-11 20:16:52]

Description was changed from

==========
Remove CPDF_Object::GetConstString and overrides

GetConstString() has sharp edges in that when applied to
a CPDF_Number, it must null whereas GetString() returns
a the stringified number, because of the inability to
control the lifetime of an allocated string.

Deleting this method showed several places where we
actually wanted a *String, not a *StringC, so we were
re-allocating a string we already had.
==========

to

==========
Remove CPDF_Object::GetConstString and overrides

GetConstString() has sharp edges in that when applied to
a CPDF_Number, it must return null whereas GetString() returns
a the stringified number, because of the inability to
control the lifetime of the underlying allocated string.

Deleting this method showed several places where we
actually wanted a *String, not a *StringC, so we were
re-allocating a string we already had.
==========

[Tom Sepez, 2016-04-11 20:16:52]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-11 20:17:13]

Lei, 180 degree about-face.

[Tom Sepez, 2016-04-11 20:19:46]

https://codereview.chromium.org/1879683002/diff/1/core/fpdfapi/fpdf_page/fpdf...
File core/fpdfapi/fpdf_page/fpdf_page_doc.cpp (right):

https://codereview.chromium.org/1879683002/diff/1/core/fpdfapi/fpdf_page/fpdf...
core/fpdfapi/fpdf_page/fpdf_page_doc.cpp:329: CFX_ByteString name =
pCSObj->GetString();
note: avoids a duplicate alloc here.

https://codereview.chromium.org/1879683002/diff/1/core/fpdfapi/fpdf_parser/fp...
File core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp (right):

https://codereview.chromium.org/1879683002/diff/1/core/fpdfapi/fpdf_parser/fp...
core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp:353:
DecoderList.push_back(pDecoders->GetStringAt(i));
and here.

https://codereview.chromium.org/1879683002/diff/1/core/fpdfapi/fpdf_parser/fp...
core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp:357:
DecoderList.push_back(pDecoder->GetString());
and here.

https://codereview.chromium.org/1879683002/diff/1/core/fpdfdoc/doc_annot.cpp
File core/fpdfdoc/doc_annot.cpp (right):

https://codereview.chromium.org/1879683002/diff/1/core/fpdfdoc/doc_annot.cpp#...
core/fpdfdoc/doc_annot.cpp:130: m_sSubtype(m_pAnnotDict->GetStringBy("Subtype"))
{}
and here.

[Lei Zhang, 2016-04-11 21:57:34]

lgtm

https://codereview.chromium.org/1879683002/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render_image.cpp (right):

https://codereview.chromium.org/1879683002/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:885: FX_BOOL bLuminosity =
pSMaskDict->GetStringBy("S") != "Alpha";
You can also move this down, closer to where it's used. Along with |width| and
|height|.

[Tom Sepez, 2016-04-12 00:45:28]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-12 00:45:29]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1879683002/#ps20001
(title: "Move bLuminosity down.")

[commit-bot: I haz the power, 2016-04-12 00:45:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879683002/20001

[commit-bot: I haz the power, 2016-04-12 01:14:58]

Description was changed from

==========
Remove CPDF_Object::GetConstString and overrides

GetConstString() has sharp edges in that when applied to
a CPDF_Number, it must return null whereas GetString() returns
a the stringified number, because of the inability to
control the lifetime of the underlying allocated string.

Deleting this method showed several places where we
actually wanted a *String, not a *StringC, so we were
re-allocating a string we already had.
==========

to

==========
Remove CPDF_Object::GetConstString and overrides

GetConstString() has sharp edges in that when applied to
a CPDF_Number, it must return null whereas GetString() returns
a the stringified number, because of the inability to
control the lifetime of the underlying allocated string.

Deleting this method showed several places where we
actually wanted a *String, not a *StringC, so we were
re-allocating a string we already had.

Committed:
https://pdfium.googlesource.com/pdfium/+/822484b5f88d92dbcd567b1c2da38af1e720...
==========

[commit-bot: I haz the power, 2016-04-12 01:14:59]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/822484b5f88d92dbcd567b1c2da38af1e720...