Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: core/fpdfapi/fpdf_parser/include/cpdf_reference.h

Issue 1879683002: Remove CPDF_Object::GetConstString and overrides (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Move bLuminosity down. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_REFERENCE_H_ 7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_REFERENCE_H_
8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_REFERENCE_H_ 8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_REFERENCE_H_
9 9
10 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h" 10 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"
11 11
12 class CPDF_IndirectObjectHolder; 12 class CPDF_IndirectObjectHolder;
13 13
14 class CPDF_Reference : public CPDF_Object { 14 class CPDF_Reference : public CPDF_Object {
15 public: 15 public:
16 CPDF_Reference(CPDF_IndirectObjectHolder* pDoc, int objnum); 16 CPDF_Reference(CPDF_IndirectObjectHolder* pDoc, int objnum);
17 17
18 // CPDF_Object. 18 // CPDF_Object.
19 Type GetType() const override; 19 Type GetType() const override;
20 CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override; 20 CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;
21 CPDF_Object* GetDirect() const override; 21 CPDF_Object* GetDirect() const override;
22 CFX_ByteString GetString() const override; 22 CFX_ByteString GetString() const override;
23 CFX_ByteStringC GetConstString() const override;
24 FX_FLOAT GetNumber() const override; 23 FX_FLOAT GetNumber() const override;
25 int GetInteger() const override; 24 int GetInteger() const override;
26 CPDF_Dictionary* GetDict() const override; 25 CPDF_Dictionary* GetDict() const override;
27 26
28 // TODO(weili): check whether GetUnicodeText() and GetArray() are needed. 27 // TODO(weili): check whether GetUnicodeText() and GetArray() are needed.
29 bool IsReference() const override; 28 bool IsReference() const override;
30 CPDF_Reference* AsReference() override; 29 CPDF_Reference* AsReference() override;
31 const CPDF_Reference* AsReference() const override; 30 const CPDF_Reference* AsReference() const override;
32 31
33 CPDF_IndirectObjectHolder* GetObjList() const { return m_pObjList; } 32 CPDF_IndirectObjectHolder* GetObjList() const { return m_pObjList; }
34 uint32_t GetRefObjNum() const { return m_RefObjNum; } 33 uint32_t GetRefObjNum() const { return m_RefObjNum; }
35 34
36 void SetRef(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum); 35 void SetRef(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum);
37 36
38 protected: 37 protected:
39 ~CPDF_Reference() override; 38 ~CPDF_Reference() override;
40 CPDF_Object* SafeGetDirect() const { 39 CPDF_Object* SafeGetDirect() const {
41 CPDF_Object* obj = GetDirect(); 40 CPDF_Object* obj = GetDirect();
42 if (!obj || obj->IsReference()) 41 if (!obj || obj->IsReference())
43 return nullptr; 42 return nullptr;
44 return obj; 43 return obj;
45 } 44 }
46 45
47 CPDF_IndirectObjectHolder* m_pObjList; 46 CPDF_IndirectObjectHolder* m_pObjList;
48 uint32_t m_RefObjNum; 47 uint32_t m_RefObjNum;
49 }; 48 };
50 49
51 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_REFERENCE_H_ 50 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_REFERENCE_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_parser/include/cpdf_object.h ('k') | core/fpdfapi/fpdf_parser/include/cpdf_string.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698