core/fpdfapi/fpdf_parser/cpdf_reference.cpp - Issue 1879683002: Remove CPDF_Object::GetConstString and overrides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_reference.cpp

Issue 1879683002: Remove CPDF_Object::GetConstString and overrides (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Move bLuminosity down. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_reference.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_reference.cpp b/core/fpdfapi/fpdf_parser/cpdf_reference.cpp

index 9053d08b368533ac5eb3c74a710149cb010edfb1..007423e5fb247c6d138a9ae3395fd3aebfb38011 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_reference.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_reference.cpp

@@ -22,11 +22,6 @@ CFX_ByteString CPDF_Reference::GetString() const {

return obj ? obj->GetString() : CFX_ByteString();

}

-CFX_ByteStringC CPDF_Reference::GetConstString() const {

- CPDF_Object* obj = SafeGetDirect();

- return obj ? obj->GetConstString() : CFX_ByteStringC();

FX_FLOAT CPDF_Reference::GetNumber() const {

CPDF_Object* obj = SafeGetDirect();

return obj ? obj->GetNumber() : 0;