Implement modular compilation

Implement modular compilation

Highlights
* compile one module at a time
* use summaries to speed up compiles
* use command runner so we can add more commands later
* some long needed renames and file organization
* various other technical debt has been addressed

Lowlights
* lost node.js runner/tests (node output format still supported)
* possibly lost some closure support/workarounds (format still supported)
* needs more end-to-end tests of the new system

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/2607e182f7eab072c514be8f5325f50144029a4a

[Jennifer Messerly, 2016-04-13 23:40:50]

Description was changed from

==========
Implement modular compilation

Highlights
* compile module at a time
* use summaries to speed up compiles
* use command runner so we can add more commands later
* some long needed renames and file organization
* various other technical debt has been addressed

Lowlights
* lost node.js runner/tests (node output format still supported)
* possibly lost some closure support/workarounds (format still supported)
* needs more end-to-end tests of the new system
==========

to

==========
Implement modular compilation

Highlights
* compile one module at a time
* use summaries to speed up compiles
* use command runner so we can add more commands later
* some long needed renames and file organization
* various other technical debt has been addressed

Lowlights
* lost node.js runner/tests (node output format still supported)
* possibly lost some closure support/workarounds (format still supported)
* needs more end-to-end tests of the new system
==========

[Jennifer Messerly, 2016-04-13 23:40:50]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-04-13 23:42:48]

This is now passing for me locally. I still need to investigate what's going on
with Travis:
https://travis-ci.org/dart-lang/dev_compiler/jobs/122928873

But if you want to start taking a look, feel free. Probably it's something
fairly simple.

This is also pushed to
https://github.com/dart-lang/dev_compiler/tree/buildtarget

[vsm, 2016-04-14 00:18:24]

lgtm!

https://codereview.chromium.org/1879373004/diff/1/bin/dartdevc.dart
File bin/dartdevc.dart (right):

https://codereview.chromium.org/1879373004/diff/1/bin/dartdevc.dart#newcode29
bin/dartdevc.dart:29: ///   existing tools such as for the "link" step, or
assume users have a local
such as ??? for link step?

https://codereview.chromium.org/1879373004/diff/1/karma.conf.js
File karma.conf.js (right):

https://codereview.chromium.org/1879373004/diff/1/karma.conf.js#newcode84
karma.conf.js:84: browsers: ['Chrome', 'Electron'],
This should work now with the patch I suggested.  Note that travis on line 92 is
still using canary.

https://codereview.chromium.org/1879373004/diff/1/lib/runtime/dart_library.js
File lib/runtime/dart_library.js (right):

https://codereview.chromium.org/1879373004/diff/1/lib/runtime/dart_library.js...
lib/runtime/dart_library.js:79: let result = new LibraryLoader(name,
defaultValue, imports, lazyImports, loader);
Drop lazyImports in the two lines above.  :-)

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:842: /// Gets the JS pper for this Dart
type, if any, otherwise null.
pper -> peer

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/compiler.dart
File lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/compiler.d...
lib/src/compiler/compiler.dart:22: /// For a single [BuildUnit] definition, this
will produce a [JSModuleFile] output.
nit length

[Jennifer Messerly, 2016-04-14 18:28:17]

Description was changed from

==========
Implement modular compilation

Highlights
* compile one module at a time
* use summaries to speed up compiles
* use command runner so we can add more commands later
* some long needed renames and file organization
* various other technical debt has been addressed

Lowlights
* lost node.js runner/tests (node output format still supported)
* possibly lost some closure support/workarounds (format still supported)
* needs more end-to-end tests of the new system
==========

to

==========
Implement modular compilation

Highlights
* compile one module at a time
* use summaries to speed up compiles
* use command runner so we can add more commands later
* some long needed renames and file organization
* various other technical debt has been addressed

Lowlights
* lost node.js runner/tests (node output format still supported)
* possibly lost some closure support/workarounds (format still supported)
* needs more end-to-end tests of the new system

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/2607e182f7eab072c514be8f5325...
==========

[Jennifer Messerly, 2016-04-14 18:28:20]

Committed patchset #3 (id:20001) manually as
2607e182f7eab072c514be8f5325f50144029a4a (presubmit successful).

[Jennifer Messerly, 2016-04-14 18:28:40]

Thanks!

https://codereview.chromium.org/1879373004/diff/1/bin/dartdevc.dart
File bin/dartdevc.dart (right):

https://codereview.chromium.org/1879373004/diff/1/bin/dartdevc.dart#newcode29
bin/dartdevc.dart:29: ///   existing tools such as for the "link" step, or
assume users have a local
On 2016/04/14 00:18:24, vsm wrote:
> such as ??? for link step?

I was thinking of webpack: https://webpack.github.io/

There are many related/historical tools as well (browserify, requirejs, various
gulp plugins, even things like Closure Compiler fit in the "linker" category)

but yeah, I started going into detail then I meant to edit out specific tools.
Oops. Fixed :)

https://codereview.chromium.org/1879373004/diff/1/karma.conf.js
File karma.conf.js (right):

https://codereview.chromium.org/1879373004/diff/1/karma.conf.js#newcode84
karma.conf.js:84: browsers: ['Chrome', 'Electron'],
On 2016/04/14 00:18:24, vsm wrote:
> This should work now with the patch I suggested.  Note that travis on line 92
is
> still using canary.

Ah yeah, I'll try that.

Not related to this review, but: At some point should Chrome be the default for
use with DDC? It might be more reliable for Dart developers than Canary. That
said, maybe we'll always want the bleeding edge V8 goodness on Canary. Certainly
so far it's been useful to test against it. (And we have Electron anyway keeping
us honest on the older Chrome support.)

https://codereview.chromium.org/1879373004/diff/1/lib/runtime/dart_library.js
File lib/runtime/dart_library.js (right):

https://codereview.chromium.org/1879373004/diff/1/lib/runtime/dart_library.js...
lib/runtime/dart_library.js:79: let result = new LibraryLoader(name,
defaultValue, imports, lazyImports, loader);
On 2016/04/14 00:18:24, vsm wrote:
> Drop lazyImports in the two lines above.  :-)

oops, good catch. I thought I'd searched this file for "lazy". DOH.

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:842: /// Gets the JS pper for this Dart
type, if any, otherwise null.
On 2016/04/14 00:18:24, vsm wrote:
> pper -> peer

Done.

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/compiler.dart
File lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/1879373004/diff/1/lib/src/compiler/compiler.d...
lib/src/compiler/compiler.dart:22: /// For a single [BuildUnit] definition, this
will produce a [JSModuleFile] output.
On 2016/04/14 00:18:24, vsm wrote:
> nit length

Done.