Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 1879103002: Convert main-thread overscroll parameters into viewport space. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Majid's review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClient.h
diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h
index 3057804174f8698b691e36b43c9dddabf82d9f34..2e960050fd6ce913eb12a8eee2264a6936bbcb06 100644
--- a/third_party/WebKit/Source/core/page/ChromeClient.h
+++ b/third_party/WebKit/Source/core/page/ChromeClient.h
@@ -106,7 +106,15 @@ public:
void setWindowFeatures(const WindowFeatures&);
- virtual void didOverscroll(const FloatSize&, const FloatSize&, const FloatPoint&, const FloatSize&) = 0;
+ // All the parameters should be in viewport space. That is, if an event
+ // scrolls by 10 px, but due to a 2X page scale we apply a 5px scroll to the
+ // root frame, all of which is handled as overscroll, we should return 10px
+ // as the overscrollDelta.
+ virtual void didOverscroll(
+ const FloatSize& overscrollDelta,
+ const FloatSize& accumulatedOverscroll,
+ const FloatPoint& positionInViewport,
+ const FloatSize& velocityInViewport) = 0;
virtual void setToolbarsVisible(bool) = 0;
virtual bool toolbarsVisible() = 0;
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698