Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 1879103002: Convert main-thread overscroll parameters into viewport space. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Majid's review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 // LocalFrame wants to create the new Page. Also, the newly created window 99 // LocalFrame wants to create the new Page. Also, the newly created window
100 // should not be shown to the user until the ChromeClient of the newly 100 // should not be shown to the user until the ChromeClient of the newly
101 // created Page has its show method called. 101 // created Page has its show method called.
102 // The FrameLoadRequest parameter is only for ChromeClient to check if the 102 // The FrameLoadRequest parameter is only for ChromeClient to check if the
103 // request could be fulfilled. The ChromeClient should not load the request. 103 // request could be fulfilled. The ChromeClient should not load the request.
104 virtual Page* createWindow(LocalFrame*, const FrameLoadRequest&, const Windo wFeatures&, NavigationPolicy, ShouldSetOpener) = 0; 104 virtual Page* createWindow(LocalFrame*, const FrameLoadRequest&, const Windo wFeatures&, NavigationPolicy, ShouldSetOpener) = 0;
105 virtual void show(NavigationPolicy = NavigationPolicyIgnore) = 0; 105 virtual void show(NavigationPolicy = NavigationPolicyIgnore) = 0;
106 106
107 void setWindowFeatures(const WindowFeatures&); 107 void setWindowFeatures(const WindowFeatures&);
108 108
109 virtual void didOverscroll(const FloatSize&, const FloatSize&, const FloatPo int&, const FloatSize&) = 0; 109 // All the parameters should be in viewport space. That is, if an event
110 // scrolls by 10 px, but due to a 2X page scale we apply a 5px scroll to the
111 // root frame, all of which is handled as overscroll, we should return 10px
112 // as the overscrollDelta.
113 virtual void didOverscroll(
114 const FloatSize& overscrollDelta,
115 const FloatSize& accumulatedOverscroll,
116 const FloatPoint& positionInViewport,
117 const FloatSize& velocityInViewport) = 0;
110 118
111 virtual void setToolbarsVisible(bool) = 0; 119 virtual void setToolbarsVisible(bool) = 0;
112 virtual bool toolbarsVisible() = 0; 120 virtual bool toolbarsVisible() = 0;
113 121
114 virtual void setStatusbarVisible(bool) = 0; 122 virtual void setStatusbarVisible(bool) = 0;
115 virtual bool statusbarVisible() = 0; 123 virtual bool statusbarVisible() = 0;
116 124
117 virtual void setScrollbarsVisible(bool) = 0; 125 virtual void setScrollbarsVisible(bool) = 0;
118 virtual bool scrollbarsVisible() = 0; 126 virtual bool scrollbarsVisible() = 0;
119 127
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 286
279 LayoutPoint m_lastToolTipPoint; 287 LayoutPoint m_lastToolTipPoint;
280 String m_lastToolTipText; 288 String m_lastToolTipText;
281 289
282 FRIEND_TEST_ALL_PREFIXES(ChromeClientTest, SetToolTipFlood); 290 FRIEND_TEST_ALL_PREFIXES(ChromeClientTest, SetToolTipFlood);
283 }; 291 };
284 292
285 } // namespace blink 293 } // namespace blink
286 294
287 #endif // ChromeClient_h 295 #endif // ChromeClient_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698