third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 1879103002: Convert main-thread overscroll parameters into viewport space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 1879103002: Convert main-thread overscroll parameters into viewport space. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Majid's review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index a6d22adfa96df0570ba42b5392eec2d805837528..0fce6d55918fab1628bd2c081515d8f1753b492c 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -66,7 +66,11 @@ public:

Page* createWindow(

LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationPolicy, ShouldSetOpener) override;

void show(NavigationPolicy) override;

- void didOverscroll(const FloatSize&, const FloatSize&, const FloatPoint&, const FloatSize&) override;

+ void didOverscroll(

+ const FloatSize& overscrollDelta,

+ const FloatSize& accumulatedOverscroll,

+ const FloatPoint& positionInViewport,

+ const FloatSize& velocityInViewport) override;

void setToolbarsVisible(bool) override;

bool toolbarsVisible() override;

void setStatusbarVisible(bool) override;

« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.h ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »