Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1879033002: Print messages when aborting background compilation (--trace-compiler); turn on background compilat… (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print messages when aborting background compilation (--trace-compiler); turn on background compilation; mark a slow test. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/80ba69dfdb72541f512ea760274ae335618b6f2e

Patch Set 1 #

Patch Set 2 : s #

Patch Set 3 : text #

Total comments: 2

Patch Set 4 : Fix background compilation: dp not allocate in new #

Patch Set 5 : fix background compilation #

Patch Set 6 : add timeline info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -23 lines) Patch
M runtime/vm/block_scheduler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/compiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 4 5 5 chunks +18 lines, -6 lines 0 comments Download
M runtime/vm/flag_list.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 8 months ago (2016-04-12 17:27:26 UTC) #2
rmacnak
lgtm w/ suggestion https://chromiumcodereview.appspot.com/1879033002/diff/40001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://chromiumcodereview.appspot.com/1879033002/diff/40001/runtime/vm/compiler.cc#newcode1587 runtime/vm/compiler.cc:1587: THR_Print("ABORT background compilation: %s\n", msg); I ...
4 years, 8 months ago (2016-04-12 18:00:47 UTC) #3
srdjan
Committed patchset #6 (id:100001) manually as 80ba69dfdb72541f512ea760274ae335618b6f2e (presubmit successful).
4 years, 8 months ago (2016-04-12 18:20:01 UTC) #5
srdjan
4 years, 8 months ago (2016-04-26 21:09:25 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1879033002/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1879033002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1587: THR_Print("ABORT background compilation: %s\n",
msg);
On 2016/04/12 18:00:46, rmacnak wrote:
> I suggest including a timeline event.
> 
> TimelineStream* stream = Timeline::GetCompilerStream();
> ASSERT(stream != NULL);
> TimelineEvent* event = stream->StartEvent();
> if (event != NULL) {
>   event->Instant("AbortBackgroundCompilation");
>   event->SetNumArguments(1);
>   event->CopyArgument(0, "reason", msg);
>   event->Complete();
> }

Done.

Powered by Google App Engine
This is Rietveld 408576698