Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 1879033002: Print messages when aborting background compilation (--trace-compiler); turn on background compilat… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: add timeline info Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 1594 matching lines...) Expand 10 before | Expand all | Expand 10 after
1605 ASSERT(sizeof(classid_t) == kInt16Size); 1605 ASSERT(sizeof(classid_t) == kInt16Size);
1606 __ Comment("GuardFieldClassInstr"); 1606 __ Comment("GuardFieldClassInstr");
1607 1607
1608 const intptr_t value_cid = value()->Type()->ToCid(); 1608 const intptr_t value_cid = value()->Type()->ToCid();
1609 const intptr_t field_cid = field().guarded_cid(); 1609 const intptr_t field_cid = field().guarded_cid();
1610 const intptr_t nullability = field().is_nullable() ? kNullCid : kIllegalCid; 1610 const intptr_t nullability = field().is_nullable() ? kNullCid : kIllegalCid;
1611 1611
1612 if (field_cid == kDynamicCid) { 1612 if (field_cid == kDynamicCid) {
1613 if (Compiler::IsBackgroundCompilation()) { 1613 if (Compiler::IsBackgroundCompilation()) {
1614 // Field state changed while compiling. 1614 // Field state changed while compiling.
1615 Compiler::AbortBackgroundCompilation(deopt_id()); 1615 Compiler::AbortBackgroundCompilation(deopt_id(),
1616 "GuardFieldClassInstr: field state changed while compiling");
1616 } 1617 }
1617 ASSERT(!compiler->is_optimizing()); 1618 ASSERT(!compiler->is_optimizing());
1618 return; // Nothing to emit. 1619 return; // Nothing to emit.
1619 } 1620 }
1620 1621
1621 const bool emit_full_guard = 1622 const bool emit_full_guard =
1622 !compiler->is_optimizing() || (field_cid == kIllegalCid); 1623 !compiler->is_optimizing() || (field_cid == kIllegalCid);
1623 1624
1624 const bool needs_value_cid_temp_reg = 1625 const bool needs_value_cid_temp_reg =
1625 (value_cid == kDynamicCid) && (emit_full_guard || (field_cid != kSmiCid)); 1626 (value_cid == kDynamicCid) && (emit_full_guard || (field_cid != kSmiCid));
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
1763 return summary; 1764 return summary;
1764 } 1765 }
1765 UNREACHABLE(); 1766 UNREACHABLE();
1766 } 1767 }
1767 1768
1768 1769
1769 void GuardFieldLengthInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1770 void GuardFieldLengthInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1770 if (field().guarded_list_length() == Field::kNoFixedLength) { 1771 if (field().guarded_list_length() == Field::kNoFixedLength) {
1771 if (Compiler::IsBackgroundCompilation()) { 1772 if (Compiler::IsBackgroundCompilation()) {
1772 // Field state changed while compiling. 1773 // Field state changed while compiling.
1773 Compiler::AbortBackgroundCompilation(deopt_id()); 1774 Compiler::AbortBackgroundCompilation(deopt_id(),
1775 "GuardFieldLengthInstr: field state changed while compiling");
1774 } 1776 }
1775 ASSERT(!compiler->is_optimizing()); 1777 ASSERT(!compiler->is_optimizing());
1776 return; // Nothing to emit. 1778 return; // Nothing to emit.
1777 } 1779 }
1778 1780
1779 Label* deopt = compiler->is_optimizing() ? 1781 Label* deopt = compiler->is_optimizing() ?
1780 compiler->AddDeoptStub(deopt_id(), ICData::kDeoptGuardField) : NULL; 1782 compiler->AddDeoptStub(deopt_id(), ICData::kDeoptGuardField) : NULL;
1781 1783
1782 const Register value_reg = locs()->in(0).reg(); 1784 const Register value_reg = locs()->in(0).reg();
1783 1785
(...skipping 3926 matching lines...) Expand 10 before | Expand all | Expand 10 after
5710 1, 5712 1,
5711 locs()); 5713 locs());
5712 __ lw(result, Address(SP, 1 * kWordSize)); 5714 __ lw(result, Address(SP, 1 * kWordSize));
5713 __ addiu(SP, SP, Immediate(2 * kWordSize)); 5715 __ addiu(SP, SP, Immediate(2 * kWordSize));
5714 } 5716 }
5715 5717
5716 5718
5717 } // namespace dart 5719 } // namespace dart
5718 5720
5719 #endif // defined TARGET_ARCH_MIPS 5721 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698