runtime/vm/intermediate_language.cc - Issue 1879033002: Print messages when aborting background compilation (--trace-compiler); turn on background compilat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 1879033002: Print messages when aborting background compilation (--trace-compiler); turn on background compilat… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: add timeline info Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index 3e6487d564c533d8f800de9e422e2475fefa435f..c68f277692311605272ee04f5a0cced09fcf3624 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -3510,7 +3510,8 @@ Definition* StringInterpolateInstr::Canonicalize(FlowGraph* flow_graph) {

pieces.SetAt(store_index, String::Cast(obj));

} else if (obj.IsSmi()) {

const char* cstr = obj.ToCString();

- pieces.SetAt(store_index, String::Handle(zone, String::New(cstr)));

+ pieces.SetAt(store_index,

+ String::Handle(zone, String::New(cstr, Heap::kOld)));

} else if (obj.IsBool()) {

pieces.SetAt(store_index,

Bool::Cast(obj).value() ? Symbols::True() : Symbols::False());

« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »