Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1878583002: Refactor SVGTextLayoutAttributesBuilder::collectTextPositioningElements (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-17
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor SVGTextLayoutAttributesBuilder::collectTextPositioningElements This moves the creation of a TextPosition element for the <text> into collectTextPositioningElements too, getting rid of the special case. BUG=594058 Committed: https://crrev.com/eb4114c47acb1a944c5b68e9d6486c68e01fc311 Cr-Commit-Position: refs/heads/master@{#386622}

Patch Set 1 #

Patch Set 2 : Use for-range loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -27 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 1 2 chunks +17 lines, -27 lines 0 comments Download

Depends on Patchset:

Issue 1871393003 Patch 20001

Messages

Total messages: 8 (3 generated)
fs
4 years, 8 months ago (2016-04-11 11:56:21 UTC) #2
pdr.
On 2016/04/11 at 11:56:21, fs wrote: > LGTM
4 years, 8 months ago (2016-04-12 03:45:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878583002/20001
4 years, 8 months ago (2016-04-12 08:11:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 08:17:28 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:19:00 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eb4114c47acb1a944c5b68e9d6486c68e01fc311
Cr-Commit-Position: refs/heads/master@{#386622}

Powered by Google App Engine
This is Rietveld 408576698