Refactor SVGTextLayoutAttributesBuilder::collectTextPositioningElements

third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

 /*
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 95 matching lines @@
     Node* node = layoutObject.node();
     ASSERT(node);
     ASSERT(node->isSVGElement());
 
     return isSVGTextPositioningElement(*node) ? toSVGTextPositioningElement(node) : nullptr;
 }
 
 void SVGTextLayoutAttributesBuilder::collectTextPositioningElements(LayoutBoxModelObject& start)
 {
     ASSERT(!start.isSVGText() || m_textPositions.isEmpty());
+    SVGTextPositioningElement* element = positioningElementFromLayoutObject(start);
+    unsigned atPosition = m_textPositions.size();
+    if (element)
+        m_textPositions.append(TextPosition(element, m_characterCount));
 
     for (LayoutObject* child = start.slowFirstChild(); child; child = child->nextSibling()) {
         if (child->isSVGInlineText()) {
             m_characterCount += countCharactersInTextNode(toLayoutSVGInlineText(*child));
             continue;
         }
 
-        if (!child->isSVGInline())
+        if (child->isSVGInline()) {
+            collectTextPositioningElements(toLayoutSVGInline(*child));
             continue;
+        }
+    }
 
-        LayoutSVGInline& inlineChild = toLayoutSVGInline(*child);
-        SVGTextPositioningElement* element = positioningElementFromLayoutObject(inlineChild);
-        unsigned atPosition = m_textPositions.size();
-        if (element)
-            m_textPositions.append(TextPosition(element, m_characterCount));
+    if (!element)
+        return;
 
-        collectTextPositioningElements(inlineChild);
-
-        if (!element)
-            continue;
-
-        // Update text position, after we're back from recursion.
-        TextPosition& position = m_textPositions[atPosition];
-        ASSERT(!position.length);
-        position.length = m_characterCount - position.start;
-    }
+    // Compute the length of the subtree after all children have been visited.
+    TextPosition& position = m_textPositions[atPosition];
+    ASSERT(!position.length);
+    position.length = m_characterCount - position.start;
 }
 
 void SVGTextLayoutAttributesBuilder::buildCharacterDataMap(LayoutSVGText& textRoot)
 {
-    SVGTextPositioningElement* outermostTextElement = positioningElementFromLayoutObject(textRoot);
-    ASSERT(outermostTextElement);
-
-    // Grab outermost <text> element value lists and insert them in the character data map.
-    TextPosition wholeTextPosition(outermostTextElement, 0, m_characterCount);
-    fillCharacterDataMap(wholeTextPosition);
-
-    // Fill character data map using child text positioning elements in top-down order.
-    unsigned size = m_textPositions.size();
-    for (unsigned i = 0; i < size; ++i)
-        fillCharacterDataMap(m_textPositions[i]);
+    // Fill character data map using text positioning elements in top-down order.
+    for (const TextPosition& position : m_textPositions)
+        fillCharacterDataMap(position);
 
     // Handle x/y default attributes.
     SVGCharacterData& data = m_characterDataMap.add(1, SVGCharacterData()).storedValue->value;
     if (SVGTextLayoutAttributes::isEmptyValue(data.x))
         data.x = 0;
     if (SVGTextLayoutAttributes::isEmptyValue(data.y))
         data.y = 0;
 }
 
 namespace {
@@ skipping 76 matching lines @@
         attrLists.updateCharacterData(i, data);
     }
 }
 
 DEFINE_TRACE(SVGTextLayoutAttributesBuilder::TextPosition)
 {
     visitor->trace(element);
 }
 
 } // namespace blink