Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1871393003: Don't persist the SVGTextLayoutAttributesBuilder (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't persist the SVGTextLayoutAttributesBuilder No partial updates are performed on the structures contained within the builder, so keeping them around between layouts only amounts to memory wasted. With this change the builder is now more of a proper builder. buildLayoutAttributesForTextRoot() is folded into buildLayoutAttributes(). BUG=594058 Committed: https://crrev.com/50e8dd8ad929f02ecfa3f020a6971a9606fdb993 Cr-Commit-Position: refs/heads/master@{#386616}

Patch Set 1 #

Patch Set 2 : explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -42 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 8 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h View 1 3 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 2 chunks +18 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
fs
4 years, 8 months ago (2016-04-11 11:56:04 UTC) #3
pdr.
On 2016/04/11 at 11:56:04, fs wrote: > LGTM
4 years, 8 months ago (2016-04-12 03:44:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871393003/20001
4 years, 8 months ago (2016-04-12 07:56:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 08:01:58 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:03:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50e8dd8ad929f02ecfa3f020a6971a9606fdb993
Cr-Commit-Position: refs/heads/master@{#386616}

Powered by Google App Engine
This is Rietveld 408576698