Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1878493002: ASSERT_NOT_REACHED() -> NOTREACHED() in web. (Closed)

Created:
4 years, 8 months ago by kotenkov
Modified:
4 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, cmumford, dcheng, jsbell+idb_chromium.org, kinuko+fileapi, mlamouri+watch-blink_chromium.org, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ASSERT_NOT_REACHED() -> NOTREACHED() in web. BUG=596760 Committed: https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f Cr-Commit-Position: refs/heads/master@{#386321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -121 lines) Patch
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LocalFileSystemClient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebIDBKey.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 11 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 10 chunks +79 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kotenkov
4 years, 8 months ago (2016-04-10 21:15:33 UTC) #2
tkent
lgtm
4 years, 8 months ago (2016-04-10 23:52:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878493002/1
4 years, 8 months ago (2016-04-10 23:52:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 00:37:04 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 00:38:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f
Cr-Commit-Position: refs/heads/master@{#386321}

Powered by Google App Engine
This is Rietveld 408576698