Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1878493002: ASSERT_NOT_REACHED() -> NOTREACHED() in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/DateTimeChooserImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 const char* dialogTypeToString(ChromeClient::DialogType dialogType) 115 const char* dialogTypeToString(ChromeClient::DialogType dialogType)
116 { 116 {
117 switch (dialogType) { 117 switch (dialogType) {
118 case ChromeClient::AlertDialog: 118 case ChromeClient::AlertDialog:
119 return "alert"; 119 return "alert";
120 case ChromeClient::ConfirmDialog: 120 case ChromeClient::ConfirmDialog:
121 return "confirm"; 121 return "confirm";
122 case ChromeClient::PromptDialog: 122 case ChromeClient::PromptDialog:
123 return "prompt"; 123 return "prompt";
124 case ChromeClient::HTMLDialog: 124 case ChromeClient::HTMLDialog:
125 ASSERT_NOT_REACHED(); 125 NOTREACHED();
126 } 126 }
127 ASSERT_NOT_REACHED(); 127 NOTREACHED();
128 return ""; 128 return "";
129 } 129 }
130 130
131 const char* dismissalTypeToString(Document::PageDismissalType dismissalType) 131 const char* dismissalTypeToString(Document::PageDismissalType dismissalType)
132 { 132 {
133 switch (dismissalType) { 133 switch (dismissalType) {
134 case Document::BeforeUnloadDismissal: 134 case Document::BeforeUnloadDismissal:
135 return "beforeunload"; 135 return "beforeunload";
136 case Document::PageHideDismissal: 136 case Document::PageHideDismissal:
137 return "pagehide"; 137 return "pagehide";
138 case Document::UnloadVisibilityChangeDismissal: 138 case Document::UnloadVisibilityChangeDismissal:
139 return "visibilitychange"; 139 return "visibilitychange";
140 case Document::UnloadDismissal: 140 case Document::UnloadDismissal:
141 return "unload"; 141 return "unload";
142 case Document::NoDismissal: 142 case Document::NoDismissal:
143 ASSERT_NOT_REACHED(); 143 NOTREACHED();
144 } 144 }
145 ASSERT_NOT_REACHED(); 145 NOTREACHED();
146 return ""; 146 return "";
147 } 147 }
148 148
149 } // namespace 149 } // namespace
150 150
151 class CompositorAnimationTimeline; 151 class CompositorAnimationTimeline;
152 152
153 // Converts a AXObjectCache::AXNotification to a WebAXEvent 153 // Converts a AXObjectCache::AXNotification to a WebAXEvent
154 static WebAXEvent toWebAXEvent(AXObjectCache::AXNotification notification) 154 static WebAXEvent toWebAXEvent(AXObjectCache::AXNotification notification)
155 { 155 {
(...skipping 933 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 if (m_webView->pageImportanceSignals()) 1089 if (m_webView->pageImportanceSignals())
1090 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript(); 1090 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript();
1091 } 1091 }
1092 1092
1093 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler(BlameContex t* blameContext) 1093 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler(BlameContex t* blameContext)
1094 { 1094 {
1095 return adoptPtr(m_webView->scheduler()->createFrameScheduler(blameContext).r elease()); 1095 return adoptPtr(m_webView->scheduler()->createFrameScheduler(blameContext).r elease());
1096 } 1096 }
1097 1097
1098 } // namespace blink 1098 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/DateTimeChooserImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698