Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1878493002: ASSERT_NOT_REACHED() -> NOTREACHED() in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 if (!m_localRoot) 249 if (!m_localRoot)
250 return; 250 return;
251 251
252 PageWidgetDelegate::updateAllLifecyclePhases(*page(), *m_localRoot->frame()) ; 252 PageWidgetDelegate::updateAllLifecyclePhases(*page(), *m_localRoot->frame()) ;
253 updateLayerTreeBackgroundColor(); 253 updateLayerTreeBackgroundColor();
254 } 254 }
255 255
256 void WebFrameWidgetImpl::paint(WebCanvas* canvas, const WebRect& rect) 256 void WebFrameWidgetImpl::paint(WebCanvas* canvas, const WebRect& rect)
257 { 257 {
258 // Out-of-process iframes require compositing. 258 // Out-of-process iframes require compositing.
259 ASSERT_NOT_REACHED(); 259 NOTREACHED();
260 } 260 }
261 261
262 262
263 void WebFrameWidgetImpl::updateLayerTreeViewport() 263 void WebFrameWidgetImpl::updateLayerTreeViewport()
264 { 264 {
265 if (!page() || !m_layerTreeView) 265 if (!page() || !m_layerTreeView)
266 return; 266 return;
267 267
268 // FIXME: We need access to page scale information from the WebView. 268 // FIXME: We need access to page scale information from the WebView.
269 m_layerTreeView->setPageScaleFactorAndLimits(1, 1, 1); 269 m_layerTreeView->setPageScaleFactorAndLimits(1, 1, 1);
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 case WebInputEvent::MouseDown: 354 case WebInputEvent::MouseDown:
355 eventType = EventTypeNames::mousedown; 355 eventType = EventTypeNames::mousedown;
356 gestureIndicator = adoptPtr(new UserGestureIndicator(DefinitelyProce ssingNewUserGesture)); 356 gestureIndicator = adoptPtr(new UserGestureIndicator(DefinitelyProce ssingNewUserGesture));
357 m_mouseCaptureGestureToken = gestureIndicator->currentToken(); 357 m_mouseCaptureGestureToken = gestureIndicator->currentToken();
358 break; 358 break;
359 case WebInputEvent::MouseUp: 359 case WebInputEvent::MouseUp:
360 eventType = EventTypeNames::mouseup; 360 eventType = EventTypeNames::mouseup;
361 gestureIndicator = adoptPtr(new UserGestureIndicator(m_mouseCaptureG estureToken.release())); 361 gestureIndicator = adoptPtr(new UserGestureIndicator(m_mouseCaptureG estureToken.release()));
362 break; 362 break;
363 default: 363 default:
364 ASSERT_NOT_REACHED(); 364 NOTREACHED();
365 } 365 }
366 366
367 node->dispatchMouseEvent( 367 node->dispatchMouseEvent(
368 PlatformMouseEventBuilder(m_localRoot->frameView(), static_cast<cons t WebMouseEvent&>(inputEvent)), 368 PlatformMouseEventBuilder(m_localRoot->frameView(), static_cast<cons t WebMouseEvent&>(inputEvent)),
369 eventType, static_cast<const WebMouseEvent&>(inputEvent).clickCount) ; 369 eventType, static_cast<const WebMouseEvent&>(inputEvent).clickCount) ;
370 return WebInputEventResult::HandledSystem; 370 return WebInputEventResult::HandledSystem;
371 } 371 }
372 372
373 return PageWidgetDelegate::handleInputEvent(*this, inputEvent, m_localRoot-> frame()); 373 return PageWidgetDelegate::handleInputEvent(*this, inputEvent, m_localRoot-> frame());
374 } 374 }
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 case WebInputEvent::GestureDoubleTap: 743 case WebInputEvent::GestureDoubleTap:
744 case WebInputEvent::GestureTwoFingerTap: 744 case WebInputEvent::GestureTwoFingerTap:
745 case WebInputEvent::GestureLongPress: 745 case WebInputEvent::GestureLongPress:
746 case WebInputEvent::GestureLongTap: 746 case WebInputEvent::GestureLongTap:
747 break; 747 break;
748 case WebInputEvent::GestureFlingStart: 748 case WebInputEvent::GestureFlingStart:
749 case WebInputEvent::GestureFlingCancel: 749 case WebInputEvent::GestureFlingCancel:
750 m_client->didHandleGestureEvent(event, eventCancelled); 750 m_client->didHandleGestureEvent(event, eventCancelled);
751 return WebInputEventResult::NotHandled; 751 return WebInputEventResult::NotHandled;
752 default: 752 default:
753 ASSERT_NOT_REACHED(); 753 NOTREACHED();
754 } 754 }
755 LocalFrame* frame = m_localRoot->frame(); 755 LocalFrame* frame = m_localRoot->frame();
756 eventResult = frame->eventHandler().handleGestureEvent(PlatformGestureEventB uilder(frame->view(), event)); 756 eventResult = frame->eventHandler().handleGestureEvent(PlatformGestureEventB uilder(frame->view(), event));
757 m_client->didHandleGestureEvent(event, eventCancelled); 757 m_client->didHandleGestureEvent(event, eventCancelled);
758 return eventResult; 758 return eventResult;
759 } 759 }
760 760
761 WebInputEventResult WebFrameWidgetImpl::handleKeyEvent(const WebKeyboardEvent& e vent) 761 WebInputEventResult WebFrameWidgetImpl::handleKeyEvent(const WebKeyboardEvent& e vent)
762 { 762 {
763 DCHECK((event.type == WebInputEvent::RawKeyDown) 763 DCHECK((event.type == WebInputEvent::RawKeyDown)
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 1097
1098 HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& p osInRootFrame) 1098 HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& p osInRootFrame)
1099 { 1099 {
1100 IntPoint docPoint(m_localRoot->frame()->view()->rootFrameToContents(posInRoo tFrame)); 1100 IntPoint docPoint(m_localRoot->frame()->view()->rootFrameToContents(posInRoo tFrame));
1101 HitTestResult result = m_localRoot->frame()->eventHandler().hitTestResultAtP oint(docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active); 1101 HitTestResult result = m_localRoot->frame()->eventHandler().hitTestResultAtP oint(docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active);
1102 result.setToShadowHostIfInUserAgentShadowRoot(); 1102 result.setToShadowHostIfInUserAgentShadowRoot();
1103 return result; 1103 return result;
1104 } 1104 }
1105 1105
1106 } // namespace blink 1106 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp ('k') | third_party/WebKit/Source/web/WebIDBKey.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698