Issue 187843005: Remove stale frame ID references for RequestTransferURL.

Issue 187843005: Remove stale frame ID references for RequestTransferURL. (Closed)

Created:
6 years, 9 months ago by Charlie Reis

Modified:
6 years, 9 months ago

Reviewers:
nasko

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove stale frame ID references for RequestTransferURL. BUG=314791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255345

Patch Set 2 : Remove OpenURLParams.source_frame_id #

Patch Set 4 : Clean up and fix is_main_frame in DidStart #

Patch Set 5 : Remove incorrect check. #

Total comments: 3

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -41 lines)			Patch
M	content/browser/frame_host/navigator.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/browser/frame_host/navigator_delegate.h	View	1	1 chunk	+2 lines, -1 line	1 comment	Download
M	content/browser/frame_host/navigator_impl.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/frame_host/navigator_impl.cc	View	1 2 3	5 chunks	+7 lines, -14 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/frame_host/render_frame_host_manager.cc	View	1 2 3 4	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/security_exploit_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 2 3	3 chunks	+12 lines, -2 lines	2 comments	Download
M	content/browser/web_contents/web_contents_impl_browsertest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/frame_messages.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/browser/page_navigator.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	content/public/browser/page_navigator.cc	View	1	4 chunks	+0 lines, -4 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Nasko: I think this takes care of the rest of the old frame ID code, ...

6 years, 9 months ago (2014-03-06 00:46:49 UTC) #1

nasko

I have just one question, but overall LGTM! https://codereview.chromium.org/187843005/diff/70001/content/browser/frame_host/navigator_delegate.h File content/browser/frame_host/navigator_delegate.h (right): https://codereview.chromium.org/187843005/diff/70001/content/browser/frame_host/navigator_delegate.h#newcode97 content/browser/frame_host/navigator_delegate.h:97: virtual ...

6 years, 9 months ago (2014-03-06 04:59:51 UTC) #2

Charlie Reis

Thanks! https://codereview.chromium.org/187843005/diff/70001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/187843005/diff/70001/content/browser/web_contents/web_contents_impl.cc#newcode2031 content/browser/web_contents/web_contents_impl.cc:2031: // avoid confusing the observers. On 2014/03/06 04:59:52, ...

6 years, 9 months ago (2014-03-06 06:59:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/187843005/70001

6 years, 9 months ago (2014-03-06 07:00:11 UTC) #5

Message was sent while issue was closed.

Change committed as 255345

Expand Messages | Collapse Messages