Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 187843005: Remove stale frame ID references for RequestTransferURL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove incorrect check. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 // NavigationController know about each other. This will be possible once 84 // NavigationController know about each other. This will be possible once
85 // initialization of Navigator and NavigationController is properly done. 85 // initialization of Navigator and NavigationController is properly done.
86 virtual bool NavigateToPendingEntry( 86 virtual bool NavigateToPendingEntry(
87 RenderFrameHostImpl* render_frame_host, 87 RenderFrameHostImpl* render_frame_host,
88 NavigationController::ReloadType reload_type); 88 NavigationController::ReloadType reload_type);
89 89
90 virtual base::TimeTicks GetCurrentLoadStart(); 90 virtual base::TimeTicks GetCurrentLoadStart();
91 91
92 // The RenderFrameHostImpl has received a request to open a URL with the 92 // The RenderFrameHostImpl has received a request to open a URL with the
93 // specified |disposition|. 93 // specified |disposition|.
94 // TODO(creis): Update source_frame_id.
95 virtual void RequestOpenURL(RenderFrameHostImpl* render_frame_host, 94 virtual void RequestOpenURL(RenderFrameHostImpl* render_frame_host,
96 const GURL& url, 95 const GURL& url,
97 const Referrer& referrer, 96 const Referrer& referrer,
98 WindowOpenDisposition disposition, 97 WindowOpenDisposition disposition,
99 int64 source_frame_id,
100 bool should_replace_current_entry, 98 bool should_replace_current_entry,
101 bool user_gesture) {} 99 bool user_gesture) {}
102 100
103 // The RenderFrameHostImpl wants to transfer the request to a new renderer. 101 // The RenderFrameHostImpl wants to transfer the request to a new renderer.
104 // |redirect_chain| contains any redirect URLs (excluding |url|) that happened 102 // |redirect_chain| contains any redirect URLs (excluding |url|) that happened
105 // before the transfer. 103 // before the transfer.
106 // TODO(creis): Update source_frame_id.
107 virtual void RequestTransferURL( 104 virtual void RequestTransferURL(
108 RenderFrameHostImpl* render_frame_host, 105 RenderFrameHostImpl* render_frame_host,
109 const GURL& url, 106 const GURL& url,
110 const std::vector<GURL>& redirect_chain, 107 const std::vector<GURL>& redirect_chain,
111 const Referrer& referrer, 108 const Referrer& referrer,
112 PageTransition page_transition, 109 PageTransition page_transition,
113 WindowOpenDisposition disposition, 110 WindowOpenDisposition disposition,
114 int64 source_frame_id,
115 const GlobalRequestID& transferred_global_request_id, 111 const GlobalRequestID& transferred_global_request_id,
116 bool should_replace_current_entry, 112 bool should_replace_current_entry,
117 bool user_gesture) {} 113 bool user_gesture) {}
118 114
119 protected: 115 protected:
120 friend class base::RefCounted<Navigator>; 116 friend class base::RefCounted<Navigator>;
121 virtual ~Navigator() {} 117 virtual ~Navigator() {}
122 }; 118 };
123 119
124 } // namespace content 120 } // namespace content
125 121
126 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 122 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigator_delegate.h » ('j') | content/browser/frame_host/navigator_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698