Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: content/public/browser/page_navigator.h

Issue 187843005: Remove stale frame ID references for RequestTransferURL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove incorrect check. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // PageNavigator defines an interface that can be used to express the user's 5 // PageNavigator defines an interface that can be used to express the user's
6 // intention to navigate to a particular URL. The implementing class should 6 // intention to navigate to a particular URL. The implementing class should
7 // perform the navigation. 7 // perform the navigation.
8 8
9 #ifndef CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_ 9 #ifndef CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
10 #define CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_ 10 #define CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
(...skipping 14 matching lines...) Expand all
25 class WebContents; 25 class WebContents;
26 26
27 struct CONTENT_EXPORT OpenURLParams { 27 struct CONTENT_EXPORT OpenURLParams {
28 OpenURLParams(const GURL& url, 28 OpenURLParams(const GURL& url,
29 const Referrer& referrer, 29 const Referrer& referrer,
30 WindowOpenDisposition disposition, 30 WindowOpenDisposition disposition,
31 PageTransition transition, 31 PageTransition transition,
32 bool is_renderer_initiated); 32 bool is_renderer_initiated);
33 OpenURLParams(const GURL& url, 33 OpenURLParams(const GURL& url,
34 const Referrer& referrer, 34 const Referrer& referrer,
35 int64 source_frame_id,
36 int64 frame_tree_node_id, 35 int64 frame_tree_node_id,
37 WindowOpenDisposition disposition, 36 WindowOpenDisposition disposition,
38 PageTransition transition, 37 PageTransition transition,
39 bool is_renderer_initiated); 38 bool is_renderer_initiated);
40 ~OpenURLParams(); 39 ~OpenURLParams();
41 40
42 // The URL/referrer to be opened. 41 // The URL/referrer to be opened.
43 GURL url; 42 GURL url;
44 Referrer referrer; 43 Referrer referrer;
45 44
46 // Any redirect URLs that occurred for this navigation before |url|. 45 // Any redirect URLs that occurred for this navigation before |url|.
47 std::vector<GURL> redirect_chain; 46 std::vector<GURL> redirect_chain;
48 47
49 // Indicates whether this navigation will be sent using POST. 48 // Indicates whether this navigation will be sent using POST.
50 // The POST method is limited support for basic POST data by leveraging 49 // The POST method is limited support for basic POST data by leveraging
51 // NavigationController::LOAD_TYPE_BROWSER_INITIATED_HTTP_POST. 50 // NavigationController::LOAD_TYPE_BROWSER_INITIATED_HTTP_POST.
52 // It is not for things like file uploads. 51 // It is not for things like file uploads.
53 bool uses_post; 52 bool uses_post;
54 53
55 // The post data when the navigation uses POST. 54 // The post data when the navigation uses POST.
56 scoped_refptr<base::RefCountedMemory> browser_initiated_post_data; 55 scoped_refptr<base::RefCountedMemory> browser_initiated_post_data;
57 56
58 // Extra headers to add to the request for this page. Headers are 57 // Extra headers to add to the request for this page. Headers are
59 // represented as "<name>: <value>" and separated by \r\n. The entire string 58 // represented as "<name>: <value>" and separated by \r\n. The entire string
60 // is terminated by \r\n. May be empty if no extra headers are needed. 59 // is terminated by \r\n. May be empty if no extra headers are needed.
61 std::string extra_headers; 60 std::string extra_headers;
62 61
63 // The renderer-specific source frame id or -1 to indicate the main frame.
64 // TODO(creis): This appears to be dead code and should be removed.
65 int64 source_frame_id;
66
67 // The browser-global FrameTreeNode ID or -1 to indicate the main frame. 62 // The browser-global FrameTreeNode ID or -1 to indicate the main frame.
68 int64 frame_tree_node_id; 63 int64 frame_tree_node_id;
69 64
70 // The disposition requested by the navigation source. 65 // The disposition requested by the navigation source.
71 WindowOpenDisposition disposition; 66 WindowOpenDisposition disposition;
72 67
73 // The transition type of navigation. 68 // The transition type of navigation.
74 PageTransition transition; 69 PageTransition transition;
75 70
76 // Whether this navigation is initiated by the renderer process. 71 // Whether this navigation is initiated by the renderer process.
(...skipping 22 matching lines...) Expand all
99 // Opens a URL with the given disposition. The transition specifies how this 94 // Opens a URL with the given disposition. The transition specifies how this
100 // navigation should be recorded in the history system (for example, typed). 95 // navigation should be recorded in the history system (for example, typed).
101 // Returns the WebContents the URL is opened in, or NULL if the URL wasn't 96 // Returns the WebContents the URL is opened in, or NULL if the URL wasn't
102 // opened immediately. 97 // opened immediately.
103 virtual WebContents* OpenURL(const OpenURLParams& params) = 0; 98 virtual WebContents* OpenURL(const OpenURLParams& params) = 0;
104 }; 99 };
105 100
106 } // namespace content 101 } // namespace content
107 102
108 #endif // CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_ 103 #endif // CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698