Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: net/http/http_server_properties_manager.cc

Issue 1878273004: SHP 3: Change ServerNetworkStatsMap to use SchemeHostPort as the key. No change to Pref data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_server_properties_manager.h ('k') | net/http/http_server_properties_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_manager.cc
diff --git a/net/http/http_server_properties_manager.cc b/net/http/http_server_properties_manager.cc
index 31e8d6c489a667b2d9af8ffe17621700580e26f5..f6a121b0acb1510a4ca4f614c91931fa2f0b167a 100644
--- a/net/http/http_server_properties_manager.cc
+++ b/net/http/http_server_properties_manager.cc
@@ -345,25 +345,25 @@ void HttpServerPropertiesManager::SetSupportsQuic(bool used_quic,
}
void HttpServerPropertiesManager::SetServerNetworkStats(
- const HostPortPair& host_port_pair,
+ const url::SchemeHostPort& server,
ServerNetworkStats stats) {
DCHECK(network_task_runner_->RunsTasksOnCurrentThread());
ServerNetworkStats old_stats;
const ServerNetworkStats* old_stats_ptr =
- http_server_properties_impl_->GetServerNetworkStats(host_port_pair);
- if (http_server_properties_impl_->GetServerNetworkStats(host_port_pair))
+ http_server_properties_impl_->GetServerNetworkStats(server);
+ if (http_server_properties_impl_->GetServerNetworkStats(server))
old_stats = *old_stats_ptr;
- http_server_properties_impl_->SetServerNetworkStats(host_port_pair, stats);
+ http_server_properties_impl_->SetServerNetworkStats(server, stats);
ServerNetworkStats new_stats =
- *(http_server_properties_impl_->GetServerNetworkStats(host_port_pair));
+ *(http_server_properties_impl_->GetServerNetworkStats(server));
if (old_stats != new_stats)
ScheduleUpdatePrefsOnNetworkThread(SET_SERVER_NETWORK_STATS);
}
const ServerNetworkStats* HttpServerPropertiesManager::GetServerNetworkStats(
- const HostPortPair& host_port_pair) {
+ const url::SchemeHostPort& server) {
DCHECK(network_task_runner_->RunsTasksOnCurrentThread());
- return http_server_properties_impl_->GetServerNetworkStats(host_port_pair);
+ return http_server_properties_impl_->GetServerNetworkStats(server);
}
const ServerNetworkStatsMap&
@@ -578,7 +578,8 @@ bool HttpServerPropertiesManager::AddServersData(
AddToSpdySettingsMap(spdy_server, *server_pref_dict, spdy_settings_map);
if (!AddToAlternativeServiceMap(server, *server_pref_dict,
alternative_service_map) ||
- !AddToNetworkStatsMap(server, *server_pref_dict, network_stats_map)) {
+ !AddToNetworkStatsMap(spdy_server, *server_pref_dict,
+ network_stats_map)) {
return false;
}
}
@@ -753,7 +754,7 @@ bool HttpServerPropertiesManager::ReadSupportsQuic(
}
bool HttpServerPropertiesManager::AddToNetworkStatsMap(
- const HostPortPair& server,
+ const url::SchemeHostPort& server,
const base::DictionaryValue& server_pref_dict,
ServerNetworkStatsMap* network_stats_map) {
DCHECK(network_stats_map->Peek(server) == network_stats_map->end());
@@ -766,7 +767,7 @@ bool HttpServerPropertiesManager::AddToNetworkStatsMap(
if (!server_network_stats_dict->GetIntegerWithoutPathExpansion(kSrttKey,
&srtt)) {
DVLOG(1) << "Malformed ServerNetworkStats for server: "
- << server.ToString();
+ << server.Serialize();
return false;
}
ServerNetworkStats server_network_stats;
@@ -1092,7 +1093,9 @@ void HttpServerPropertiesManager::UpdatePrefsOnPrefThread(
for (ServerNetworkStatsMap::const_reverse_iterator map_it =
server_network_stats_map->rbegin();
map_it != server_network_stats_map->rend(); ++map_it) {
- const HostPortPair& server = map_it->first;
+ // TODO(zhongyi): use memory data once disk data is migrated.
+ const url::SchemeHostPort spdy_server = map_it->first;
+ const HostPortPair server(spdy_server.host(), spdy_server.port());
ServerPrefMap::iterator it = server_pref_map.Get(server);
if (it == server_pref_map.end()) {
ServerPref server_pref;
« no previous file with comments | « net/http/http_server_properties_manager.h ('k') | net/http/http_server_properties_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698