components/crash/content/app/breakpad_linux.cc - Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/breakpad_linux.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/command.cc ('k') | components/omnibox/browser/in_memory_url_index_unittest.cc » ('j') | net/quic/test_tools/crypto_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/content/app/breakpad_linux.cc

diff --git a/components/crash/content/app/breakpad_linux.cc b/components/crash/content/app/breakpad_linux.cc

index aab3a98a555b9220ebcaa9484d2fd21d59959463..499101c3d51c8789c13f88cebe8b70b8664ee7b7 100644

--- a/components/crash/content/app/breakpad_linux.cc

+++ b/components/crash/content/app/breakpad_linux.cc

@@ -213,7 +213,7 @@ void my_uint64tos(char* output, uint64_t i, unsigned i_len) {

#if !defined(OS_CHROMEOS)

bool my_isxdigit(char c) {

brettw 2016/04/12 21:41:07 I think you can delete this and replace the only c

- return (c >= '0' && c <= '9') || ((c | 0x20) >= 'a' && (c | 0x20) <= 'f');

+ return base::IsAsciiDigit(c) || ((c | 0x20) >= 'a' && (c | 0x20) <= 'f');

}

#endif