Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1877813002: Clarify that Blink does not support a re-distribution across v0 and v1 shadow trees (Closed)

Created:
4 years, 8 months ago by hayato
Modified:
4 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@slotchange-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify that Blink does not support a re-distribution across v0 and v1 shadow trees I do not have a plan to support a re-distribution across v0 and v1 shadow trees. It would be better to clarify it in the comment. BUG=531990 Committed: https://crrev.com/42739d8adae310a94b87f153878a0f1d4365618b Cr-Commit-Position: refs/heads/master@{#386606}

Patch Set 1 #

Patch Set 2 : clarify #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp View 1 1 chunk +2 lines, -2 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877813002/1
4 years, 8 months ago (2016-04-11 09:27:36 UTC) #2
hayato
clarify
4 years, 8 months ago (2016-04-11 09:30:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877813002/20001
4 years, 8 months ago (2016-04-11 09:30:44 UTC) #5
hayato
PTAL https://codereview.chromium.org/1877813002/diff/20001/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp (right): https://codereview.chromium.org/1877813002/diff/20001/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp#newcode43 third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:43: if (child.isInsertionPoint()) { Strictly speaking, this is the ...
4 years, 8 months ago (2016-04-11 09:34:40 UTC) #8
kochi
lgtm https://codereview.chromium.org/1877813002/diff/20001/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp (right): https://codereview.chromium.org/1877813002/diff/20001/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp#newcode43 third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:43: if (child.isInsertionPoint()) { On 2016/04/11 09:34:40, hayato wrote: ...
4 years, 8 months ago (2016-04-11 10:35:34 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 10:52:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877813002/20001
4 years, 8 months ago (2016-04-12 07:16:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 07:21:17 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 07:23:01 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42739d8adae310a94b87f153878a0f1d4365618b
Cr-Commit-Position: refs/heads/master@{#386606}

Powered by Google App Engine
This is Rietveld 408576698