Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

Issue 1877813002: Clarify that Blink does not support a re-distribution across v0 and v1 shadow trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@slotchange-1
Patch Set: clarify Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
diff --git a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
index 12632179e87871347659c0991a8d4657bd557cab..fca3fa5350e6904cfe7b4fb92341a08506f50ccc 100644
--- a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
+++ b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
@@ -40,8 +40,8 @@ void SlotAssignment::resolveAssignment(ShadowRoot& shadowRoot)
}
for (Node& child : NodeTraversal::childrenOf(*shadowRoot.host())) {
- if (child.isElementNode() && isActiveInsertionPoint(child)) {
- // TODO(hayato): Support re-distribution across v0 and v1 shadow trees
+ if (child.isInsertionPoint()) {
hayato 2016/04/11 09:34:40 Strictly speaking, this is the behavior change. Ho
kochi 2016/04/11 10:35:33 Acknowledged.
+ // A re-distribution across v0 and v1 shadow trees is not supported.
detachNotAssignedNode(child);
continue;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698