Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1872303002: Simplify slot assignments (Closed)

Created:
4 years, 8 months ago by hayato
Modified:
4 years, 8 months ago
Reviewers:
yuzuchan, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify slot assignments Handle the default slot in the same way as other slots that have the name attribute. No behavior change. BUG=531990 Committed: https://crrev.com/7a1dc49e46aca322609e96c4706d5cd26c54f409 Cr-Commit-Position: refs/heads/master@{#386604}

Patch Set 1 #

Total comments: 4

Patch Set 2 : :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -35 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp View 1 chunk +14 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872303002/1
4 years, 8 months ago (2016-04-11 09:05:38 UTC) #2
hayato
PTAL
4 years, 8 months ago (2016-04-11 09:28:42 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 10:21:00 UTC) #9
kochi
https://codereview.chromium.org/1872303002/diff/1/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/1872303002/diff/1/third_party/WebKit/Source/core/dom/Node.cpp#newcode1000 third_party/WebKit/Source/core/dom/Node.cpp:1000: return isElementNode() || isTextNode(); How about making this inline ...
4 years, 8 months ago (2016-04-11 10:57:54 UTC) #10
hayato
:)
4 years, 8 months ago (2016-04-12 04:04:56 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872303002/20001
4 years, 8 months ago (2016-04-12 04:05:17 UTC) #13
hayato
https://codereview.chromium.org/1872303002/diff/1/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/1872303002/diff/1/third_party/WebKit/Source/core/dom/Node.cpp#newcode1000 third_party/WebKit/Source/core/dom/Node.cpp:1000: return isElementNode() || isTextNode(); Done https://codereview.chromium.org/1872303002/diff/1/third_party/WebKit/Source/core/html/HTMLSlotElement.h File third_party/WebKit/Source/core/html/HTMLSlotElement.h (right): ...
4 years, 8 months ago (2016-04-12 04:06:53 UTC) #14
kochi
lgtm
4 years, 8 months ago (2016-04-12 04:34:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872303002/20001
4 years, 8 months ago (2016-04-12 04:39:30 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 07:13:34 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 07:15:15 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a1dc49e46aca322609e96c4706d5cd26c54f409
Cr-Commit-Position: refs/heads/master@{#386604}

Powered by Google App Engine
This is Rietveld 408576698