Source/core/core.gypi - Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/core.gypi

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use SimpleLifecycleObserver in addObserver / removeObserver. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/core.gypi

diff --git a/Source/core/core.gypi b/Source/core/core.gypi

index 2f519259e930441894d0a98734038e90bcb73eb3..afae50dce3d0714c3e954555624d7bfeaa61f68c 100644

--- a/Source/core/core.gypi

+++ b/Source/core/core.gypi

@@ -1182,6 +1182,10 @@

'page/PageGroup.cpp',

'page/PageGroupLoadDeferrer.cpp',

'page/PageGroupLoadDeferrer.h',

+ 'page/PageLifecycleNotifier.cpp',

+ 'page/PageLifecycleNotifier.h',

+ 'page/PageLifecycleObserver.cpp',

+ 'page/PageLifecycleObserver.h',

'page/PagePopupController.cpp',

'page/PagePopupController.h',

'page/PagePopupClient.cpp',

@@ -1904,6 +1908,12 @@

'dom/SelectorQuery.cpp',

'dom/SelectorQuery.h',

'dom/SimulatedClickOptions.h',

+ 'dom/SimpleLifecycleContext.cpp',

+ 'dom/SimpleLifecycleContext.h',

+ 'dom/SimpleLifecycleNotifier.cpp',

+ 'dom/SimpleLifecycleNotifier.h',

+ 'dom/SimpleLifecycleObserver.cpp',

+ 'dom/SimpleLifecycleObserver.h',

abarth-chromium 2013/07/08 21:25:24 The word "Simple" in a name is usually a bad sign.

Michael van Ouwerkerk 2013/07/09 17:09:12 Agreed it's not a good naming practice. These were

'dom/SpaceSplitString.cpp',

'dom/StaticNodeList.cpp',

'dom/StaticNodeList.h',

« no previous file with comments | « no previous file | Source/core/dom/ContextLifecycleNotifier.h » ('j') | Source/core/dom/SimpleLifecycleNotifier.h » ('J')