Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Side by Side Diff: Source/core/core.gypi

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use SimpleLifecycleObserver in addObserver / removeObserver. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'core_idl_files': [ 3 'core_idl_files': [
4 'css/CSS.idl', 4 'css/CSS.idl',
5 'css/CSSCharsetRule.idl', 5 'css/CSSCharsetRule.idl',
6 'css/CSSFontFaceLoadEvent.idl', 6 'css/CSSFontFaceLoadEvent.idl',
7 'css/CSSFontFaceRule.idl', 7 'css/CSSFontFaceRule.idl',
8 'css/CSSHostRule.idl', 8 'css/CSSHostRule.idl',
9 'css/CSSImportRule.idl', 9 'css/CSSImportRule.idl',
10 'css/CSSMediaRule.idl', 10 'css/CSSMediaRule.idl',
(...skipping 1164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 'page/MouseEventWithHitTestResults.h', 1175 'page/MouseEventWithHitTestResults.h',
1176 'page/Navigator.cpp', 1176 'page/Navigator.cpp',
1177 'page/Navigator.h', 1177 'page/Navigator.h',
1178 'page/NavigatorBase.cpp', 1178 'page/NavigatorBase.cpp',
1179 'page/NavigatorBase.h', 1179 'page/NavigatorBase.h',
1180 'page/Page.cpp', 1180 'page/Page.cpp',
1181 'page/PageConsole.cpp', 1181 'page/PageConsole.cpp',
1182 'page/PageGroup.cpp', 1182 'page/PageGroup.cpp',
1183 'page/PageGroupLoadDeferrer.cpp', 1183 'page/PageGroupLoadDeferrer.cpp',
1184 'page/PageGroupLoadDeferrer.h', 1184 'page/PageGroupLoadDeferrer.h',
1185 'page/PageLifecycleNotifier.cpp',
1186 'page/PageLifecycleNotifier.h',
1187 'page/PageLifecycleObserver.cpp',
1188 'page/PageLifecycleObserver.h',
1185 'page/PagePopupController.cpp', 1189 'page/PagePopupController.cpp',
1186 'page/PagePopupController.h', 1190 'page/PagePopupController.h',
1187 'page/PagePopupClient.cpp', 1191 'page/PagePopupClient.cpp',
1188 'page/PagePopupClient.h', 1192 'page/PagePopupClient.h',
1189 'page/PageScaleConstraints.cpp', 1193 'page/PageScaleConstraints.cpp',
1190 'page/PageScaleConstraints.h', 1194 'page/PageScaleConstraints.h',
1191 'page/PageScaleConstraintsSet.cpp', 1195 'page/PageScaleConstraintsSet.cpp',
1192 'page/PageScaleConstraintsSet.h', 1196 'page/PageScaleConstraintsSet.h',
1193 'page/PageSerializer.cpp', 1197 'page/PageSerializer.cpp',
1194 'page/PageVisibilityState.cpp', 1198 'page/PageVisibilityState.cpp',
(...skipping 702 matching lines...) Expand 10 before | Expand all | Expand 10 after
1897 'dom/ScriptableDocumentParser.cpp', 1901 'dom/ScriptableDocumentParser.cpp',
1898 'dom/ScriptableDocumentParser.h', 1902 'dom/ScriptableDocumentParser.h',
1899 'dom/ScriptedAnimationController.cpp', 1903 'dom/ScriptedAnimationController.cpp',
1900 'dom/ScriptedAnimationController.h', 1904 'dom/ScriptedAnimationController.h',
1901 'dom/SecurityContext.cpp', 1905 'dom/SecurityContext.cpp',
1902 'dom/SecurityContext.h', 1906 'dom/SecurityContext.h',
1903 'dom/SecurityPolicyViolationEvent.h', 1907 'dom/SecurityPolicyViolationEvent.h',
1904 'dom/SelectorQuery.cpp', 1908 'dom/SelectorQuery.cpp',
1905 'dom/SelectorQuery.h', 1909 'dom/SelectorQuery.h',
1906 'dom/SimulatedClickOptions.h', 1910 'dom/SimulatedClickOptions.h',
1911 'dom/SimpleLifecycleContext.cpp',
1912 'dom/SimpleLifecycleContext.h',
1913 'dom/SimpleLifecycleNotifier.cpp',
1914 'dom/SimpleLifecycleNotifier.h',
1915 'dom/SimpleLifecycleObserver.cpp',
1916 'dom/SimpleLifecycleObserver.h',
abarth-chromium 2013/07/08 21:25:24 The word "Simple" in a name is usually a bad sign.
Michael van Ouwerkerk 2013/07/09 17:09:12 Agreed it's not a good naming practice. These were
1907 'dom/SpaceSplitString.cpp', 1917 'dom/SpaceSplitString.cpp',
1908 'dom/StaticNodeList.cpp', 1918 'dom/StaticNodeList.cpp',
1909 'dom/StaticNodeList.h', 1919 'dom/StaticNodeList.h',
1910 'dom/StringCallback.cpp', 1920 'dom/StringCallback.cpp',
1911 'dom/StringCallback.h', 1921 'dom/StringCallback.h',
1912 'dom/StyleElement.cpp', 1922 'dom/StyleElement.cpp',
1913 'dom/StyleElement.h', 1923 'dom/StyleElement.h',
1914 'dom/TagNodeList.cpp', 1924 'dom/TagNodeList.cpp',
1915 'dom/TagNodeList.h', 1925 'dom/TagNodeList.h',
1916 'dom/Text.cpp', 1926 'dom/Text.cpp',
(...skipping 1810 matching lines...) Expand 10 before | Expand all | Expand 10 after
3727 'bison_exe': 'bison', 3737 'bison_exe': 'bison',
3728 # We specify a preprocess so it happens locally and won't get 3738 # We specify a preprocess so it happens locally and won't get
3729 # distributed to goma. 3739 # distributed to goma.
3730 # FIXME: /usr/bin/gcc won't exist on OSX forever. We want to 3740 # FIXME: /usr/bin/gcc won't exist on OSX forever. We want to
3731 # use /usr/bin/clang once we require Xcode 4.x. 3741 # use /usr/bin/clang once we require Xcode 4.x.
3732 'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"' 3742 'preprocessor': '--preprocessor "/usr/bin/gcc -E -P -x c++"'
3733 }], 3743 }],
3734 ], 3744 ],
3735 } 3745 }
3736 } 3746 }
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/ContextLifecycleNotifier.h » ('j') | Source/core/dom/SimpleLifecycleNotifier.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698