Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: Source/core/dom/ContextLifecycleNotifier.h

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use SimpleLifecycleObserver in addObserver / removeObserver. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ContextLifecycleNotifier.h
diff --git a/Source/core/dom/ContextLifecycleNotifier.h b/Source/core/dom/ContextLifecycleNotifier.h
index 4929ade1c60e76066c37489bf4a10673c99f0665..325e7f0a49df7ecf86fe0c4f072095693af0d012 100644
--- a/Source/core/dom/ContextLifecycleNotifier.h
+++ b/Source/core/dom/ContextLifecycleNotifier.h
@@ -28,6 +28,7 @@
#define ContextLifecycleNotifier_h
#include "core/dom/ActiveDOMObject.h"
+#include "core/dom/SimpleLifecycleNotifier.h"
#include "wtf/HashSet.h"
#include "wtf/PassOwnPtr.h"
@@ -41,19 +42,18 @@ class ActiveDOMObject;
class ContextLifecycleObserver;
class ScriptExecutionContext;
-class ContextLifecycleNotifier {
+class ContextLifecycleNotifier : public SimpleLifecycleNotifier {
public:
static PassOwnPtr<ContextLifecycleNotifier> create(ScriptExecutionContext*);
virtual ~ContextLifecycleNotifier();
- typedef HashSet<ContextLifecycleObserver*> ContextObserverSet;
typedef HashSet<ActiveDOMObject*> ActiveDOMObjectSet;
const ActiveDOMObjectSet& activeDOMObjects() const { return m_activeDOMObjects; }
- virtual void addObserver(ContextLifecycleObserver*, ContextLifecycleObserver::Type as);
- virtual void removeObserver(ContextLifecycleObserver*, ContextLifecycleObserver::Type as);
+ virtual void addObserver(SimpleLifecycleObserver*, SimpleLifecycleObserver::Type) OVERRIDE;
+ virtual void removeObserver(SimpleLifecycleObserver*, SimpleLifecycleObserver::Type) OVERRIDE;
void notifyResumingActiveDOMObjects();
void notifySuspendingActiveDOMObjects(ActiveDOMObject::ReasonForSuspension);
@@ -68,20 +68,8 @@ public:
protected:
explicit ContextLifecycleNotifier(ScriptExecutionContext*);
- enum IterationType {
- IteratingNone,
- IteratingOverActiveDOMObjects,
- IteratingOverContextObservers,
- IteratingOverDocumentObservers
- };
-
- IterationType m_iterating;
-
private:
- ScriptExecutionContext* m_context;
- ContextObserverSet m_contextObservers;
ActiveDOMObjectSet m_activeDOMObjects;
- bool m_inDestructor;
};
inline PassOwnPtr<ContextLifecycleNotifier> ContextLifecycleNotifier::create(ScriptExecutionContext* context)
@@ -92,4 +80,3 @@ inline PassOwnPtr<ContextLifecycleNotifier> ContextLifecycleNotifier::create(Scr
} // namespace WebCore
#endif // ContextLifecycleNotifier_h
-

Powered by Google App Engine
This is Rietveld 408576698