Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: build/config/ios/rules.gni

Issue 1877523002: Mac/iOS/GN: Generate Info.plist files for Mac apps and frameworks with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor out Info.plist generation into its own template. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 3265700309f9f5595524b5ddb7fdfa71992f3ac6..7c9a34f62aa890d0ed371fbf75c06144f7b6a946 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -47,7 +47,7 @@ template("ios_app_bundle") {
action(_generate_info_plist) {
Robert Sesek 2016/04/19 14:49:04 It would be good to re-implement this in terms of
Patti Lor 2016/04/21 08:02:09 Done.
visibility = [ ":$_bundle_data_info_plist" ]
- script = "//build/config/ios/ios_gen_plist.py"
+ script = "//build/config/mac/gen_plist.py"
sources = [
"//build/config/ios/BuildInfo.plist",
invoker.info_plist,

Powered by Google App Engine
This is Rietveld 408576698