Mac/iOS/GN: Generate Info.plist files for Mac apps and frameworks with gn.

build/config/ios/rules.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ios/ios_sdk.gni")
 import("//build/config/mac/rules.gni")
 
 # TODO(crbug.com/297668): refactor this template to extract common behaviour
 # between OS X and iOS bundle generation, then create a generic "app" template
 # that forward to "executable" on all platform except iOS/OS X.
@@ skipping 27 matching lines @@
 
   _output_name = target_name
   _target_name = target_name
   if (defined(invoker.output_name)) {
     _output_name = invoker.output_name
   }
 
   _generate_info_plist = target_name + "_generate_info_plist"
   _bundle_data_info_plist = target_name + "_bundle_data_info_plist"
 
   action(_generate_info_plist) {

[Robert Sesek, 2016/04/19 14:49:04]

It would be good to re-implement this in terms of the new info_plist template
you created. That'd mean refactoring out the common substitutions below into the
base template info_plist, with the iOS or Mac specific substitutions passed as
extra_substitutions to it. I'd create a mac_info_plist template that calls the
base info_plist template with the Mac-specific substitutions. You could do the
same for an ios_info_plist template, but since this would be the only use,
that's not yet necessary.

I did something very similar for XIB files here:
https://codereview.chromium.org/1897853003

[Patti Lor, 2016/04/21 08:02:09]

Done.

     visibility = [ ":$_bundle_data_info_plist" ]
-    script = "//build/config/ios/ios_gen_plist.py"
+    script = "//build/config/mac/gen_plist.py"
     sources = [
       "//build/config/ios/BuildInfo.plist",
       invoker.info_plist,
     ]
     outputs = [
       "$target_gen_dir/$target_name/Info.plist",
     ]
     extra_args = []
     if (defined(invoker.extra_substitutions)) {
       foreach(substitution, invoker.extra_substitutions) {
@@ skipping 325 matching lines @@
       deps = [
         ":$_framework_target",
       ]
       if (!defined(public_configs)) {
         public_configs = []
       }
       public_configs += [ ":$_framework_public_config" ]
     }
   }
 }