Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1897853003: [Mac/iOS/GN] Re-purpose the ios_compile_xib.py file to also handle Mac XIBs. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/iOS/GN] Re-purpose the ios_compile_xib.py file to also handle Mac XIBs. This leaves the existing bundle_data_xib rule for iOS but re-implements it using a new compile_xibs template. This also adds mac_xib_bundle_data to call the compile_xibs template and add a bundle_data. BUG=297668 R=sdefresne@chromium.org Committed: https://crrev.com/ef017e6f2fe72ce3cb2c2aa0150b898a044fd39c Cr-Commit-Position: refs/heads/master@{#388186}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -52 lines) Patch
D build/config/ios/ios_compile_xib.py View 1 chunk +0 lines, -34 lines 0 comments Download
M build/config/ios/rules.gni View 2 chunks +11 lines, -18 lines 0 comments Download
A build/config/mac/compile_xib.py View 1 chunk +51 lines, -0 lines 0 comments Download
M build/config/mac/rules.gni View 2 chunks +89 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 8 months ago (2016-04-19 00:07:03 UTC) #3
sdefresne
lgtm https://codereview.chromium.org/1897853003/diff/40001/build/config/mac/rules.gni File build/config/mac/rules.gni (right): https://codereview.chromium.org/1897853003/diff/40001/build/config/mac/rules.gni#newcode173 build/config/mac/rules.gni:173: "{{source}}", Nice, I didn't knew about this, I ...
4 years, 8 months ago (2016-04-19 07:09:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897853003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897853003/40001
4 years, 8 months ago (2016-04-19 11:12:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-04-19 12:02:09 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:03:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef017e6f2fe72ce3cb2c2aa0150b898a044fd39c
Cr-Commit-Position: refs/heads/master@{#388186}

Powered by Google App Engine
This is Rietveld 408576698