Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1876783002: Move two test-internal functions up to header file (Closed)

Created:
4 years, 8 months ago by Clemens Hammacher
Modified:
4 years, 8 months ago
Reviewers:
titzer, ahaas, JF
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@show-wasm-frames-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move two test-internal functions up to header file ... such that they can be reused from other tests. R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org BUG= Committed: https://crrev.com/09b50113d42eb2b18f3931ce31d54bdb78db5789 Cr-Commit-Position: refs/heads/master@{#35617}

Patch Set 1 #

Patch Set 2 : update depends-on #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -42 lines) Patch
M test/cctest/wasm/test-run-wasm-js.cc View 11 chunks +11 lines, -41 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +25 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
Clemens Hammacher
4 years, 8 months ago (2016-04-11 12:18:55 UTC) #1
ahaas
lgtm
4 years, 8 months ago (2016-04-11 12:53:01 UTC) #2
JF
lgtm
4 years, 8 months ago (2016-04-11 17:58:12 UTC) #3
titzer
On 2016/04/11 17:58:12, JF wrote: > lgtm lgtm
4 years, 8 months ago (2016-04-18 16:19:10 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1865553004 Patch 40001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-19 08:41:01 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 1865553004 Patch 40001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-19 09:14:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876783002/20001
4 years, 8 months ago (2016-04-19 12:02:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 12:23:10 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:24:49 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09b50113d42eb2b18f3931ce31d54bdb78db5789
Cr-Commit-Position: refs/heads/master@{#35617}

Powered by Google App Engine
This is Rietveld 408576698