[wasm] Flag WASM code sections as such in the tests

[wasm] Flag WASM code sections as such in the tests

This makes them show up in the stack trace. Otherwise the stack frames
are identified as type STUB, and skipped by the iterator.

R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/3e5f45b64b5da7a5d3e8afa0f1eea50203fb1ce7
Cr-Commit-Position: refs/heads/master@{#35621}

[JF, 2016-04-11 17:50:07]

Does the output of any test change because of this? It looks fine because it's
now the same as CompileWasmFunction, but I'd expect some output to change!

[Clemens Hammacher, 2016-04-11 18:28:03]

On 2016/04/11 at 17:50:07, jfb wrote:
> Does the output of any test change because of this? It looks fine because it's
now the same as CompileWasmFunction, but I'd expect some output to change!

I did not observe anything changing. It's a wasm-cctest-internal function only.

[JF, 2016-04-11 19:36:37]

On 2016/04/11 18:28:03, Clemens Hammacher wrote:
> On 2016/04/11 at 17:50:07, jfb wrote:
> > Does the output of any test change because of this? It looks fine because
it's
> now the same as CompileWasmFunction, but I'd expect some output to change!
> 
> I did not observe anything changing. It's a wasm-cctest-internal function
only.

I agree the change is correct, but it would be good to have a test exercise it
as well. How did you find it, just reading the code?

[Clemens Hammacher, 2016-04-12 07:36:03]

On 2016/04/11 at 19:36:37, jfb wrote:
> On 2016/04/11 18:28:03, Clemens Hammacher wrote:
> > On 2016/04/11 at 17:50:07, jfb wrote:
> > > Does the output of any test change because of this? It looks fine because
it's
> > now the same as CompileWasmFunction, but I'd expect some output to change!
> > 
> > I did not observe anything changing. It's a wasm-cctest-internal function
only.
> 
> I agree the change is correct, but it would be good to have a test exercise it
as well. How did you find it, just reading the code?

Oh, sure. This test case failed because of this:
https://codereview.chromium.org/1875083002
It would probably have been better to commit them together though.

[JF, 2016-04-12 18:19:11]

On 2016/04/12 07:36:03, Clemens Hammacher wrote:
> On 2016/04/11 at 19:36:37, jfb wrote:
> > On 2016/04/11 18:28:03, Clemens Hammacher wrote:
> > > On 2016/04/11 at 17:50:07, jfb wrote:
> > > > Does the output of any test change because of this? It looks fine
because
> it's
> > > now the same as CompileWasmFunction, but I'd expect some output to change!
> > > 
> > > I did not observe anything changing. It's a wasm-cctest-internal function
> only.
> > 
> > I agree the change is correct, but it would be good to have a test exercise
it
> as well. How did you find it, just reading the code?
> 
> Oh, sure. This test case failed because of this:
> https://codereview.chromium.org/1875083002
> It would probably have been better to commit them together though.

OK that's fine, lgtm

[titzer, 2016-04-18 16:24:56]

lgtm

[Clemens Hammacher, 2016-04-19 08:40:37]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-19 08:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 08:40:50]

This CL has an open dependency (Issue 1876783002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Clemens Hammacher, 2016-04-19 09:14:14]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-19 09:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 09:14:24]

This CL has an open dependency (Issue 1876783002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Clemens Hammacher, 2016-04-19 12:30:08]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-19 12:30:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878573003/20001

[commit-bot: I haz the power, 2016-04-19 12:54:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-19 12:55:06]

Description was changed from

==========
[wasm] Flag WASM code sections as such in the tests

This makes them show up in the stack trace. Otherwise the stack frames
are identified as type STUB, and skipped by the iterator.

R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
[wasm] Flag WASM code sections as such in the tests

This makes them show up in the stack trace. Otherwise the stack frames
are identified as type STUB, and skipped by the iterator.

R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/3e5f45b64b5da7a5d3e8afa0f1eea50203fb1ce7
Cr-Commit-Position: refs/heads/master@{#35621}
==========

[commit-bot: I haz the power, 2016-04-19 12:55:07]

Patchset 2 (id:??) landed as
https://crrev.com/3e5f45b64b5da7a5d3e8afa0f1eea50203fb1ce7
Cr-Commit-Position: refs/heads/master@{#35621}