[wasm] Do also output WASM frames on detailed stack traces

[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information (see new test case:
https://chromiumcodereview.appspot.com/1875083002).

R=jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/9be47f57a0c03aa56a06c5a14777b4060c631476
Cr-Commit-Position: refs/heads/master@{#35615}

[Clemens Hammacher, 2016-04-06 16:46:51]

Oh, hang on, I just recognized that the new test does not test the detailed
stack trace, but still just the simple one.
The code itself works, but I will have to write another test. I'll update this
CL tomorrow.

[Clemens Hammacher, 2016-04-11 12:09:23]

On 2016/04/06 16:46:51, ClemensHammacher wrote:
> Oh, hang on, I just recognized that the new test does not test the detailed
> stack trace, but still just the simple one.
> The code itself works, but I will have to write another test. I'll update this
> CL tomorrow.

OK, I just removed the test case for now, will upload as a separate CL. I have
mjsunit tests and cctests now.

[Clemens Hammacher, 2016-04-11 12:21:23]

Description was changed from

==========
Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information. They can also be inspected from
JavaScript by setting a prepareStackTrace function on Error (see new
test case).

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information. They can also be inspected from
JavaScript by setting a prepareStackTrace function on Error (see new
test case).

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

[JF, 2016-04-11 17:46:34]

https://codereview.chromium.org/1865553004/diff/40001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1865553004/diff/40001/src/isolate.cc#newcode550
src/isolate.cc:550: if (!fun->shared()->script()->IsUndefined()) {
In which cases is script() undefined? When coming from wasm? We'll want to add
source position for this as well, would be good to leave a todo.

[Clemens Hammacher, 2016-04-12 09:30:57]

https://codereview.chromium.org/1865553004/diff/40001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1865553004/diff/40001/src/isolate.cc#newcode550
src/isolate.cc:550: if (!fun->shared()->script()->IsUndefined()) {
On 2016/04/11 at 17:46:33, JF wrote:
> In which cases is script() undefined? When coming from wasm? We'll want to add
source position for this as well, would be good to leave a todo.

Yes, just for wasm functions. I added a TODO.

[JF, 2016-04-12 18:24:28]

lgtm

[titzer, 2016-04-18 16:27:56]

On 2016/04/12 18:24:28, JF wrote:
> lgtm

lgtm

Can you reference the testcase or the CL containing the testcase in the CL
description?

[Clemens Hammacher, 2016-04-19 08:44:17]

Description was changed from

==========
[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information. They can also be inspected from
JavaScript by setting a prepareStackTrace function on Error (see new
test case).

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information. They can also be inspected from
JavaScript by setting a prepareStackTrace function on Error (see new
test case: https://chromiumcodereview.appspot.com/1875083002).

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

[Clemens Hammacher, 2016-04-19 08:44:50]

Description was changed from

==========
[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information. They can also be inspected from
JavaScript by setting a prepareStackTrace function on Error (see new
test case: https://chromiumcodereview.appspot.com/1875083002).

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information (see new test case:
https://chromiumcodereview.appspot.com/1875083002).

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

[Clemens Hammacher, 2016-04-19 08:45:23]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-19 08:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865553004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865553004/60001

[commit-bot: I haz the power, 2016-04-19 09:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 09:26:07]

Try jobs failed on following builders:
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4468)
  v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Clemens Hammacher, 2016-04-19 09:30:34]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-19 09:30:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865553004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865553004/60001

[commit-bot: I haz the power, 2016-04-19 10:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 10:03:11]

Try jobs failed on following builders:
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4476)
  v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Clemens Hammacher, 2016-04-19 11:31:40]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-04-19 11:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
jfb@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1865553004/#ps80001
(title: "Fix gcmole reported issue")

[commit-bot: I haz the power, 2016-04-19 11:31:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865553004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865553004/80001

[commit-bot: I haz the power, 2016-04-19 11:55:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-19 11:56:55]

Description was changed from

==========
[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information (see new test case:
https://chromiumcodereview.appspot.com/1875083002).

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
[wasm] Do also output WASM frames on detailed stack traces

Till now, they were just skipped. With this patch, they now show up in
the DevTools on uncaught Errors with function name <WASM> and no line
number or file name information (see new test case:
https://chromiumcodereview.appspot.com/1875083002).

R=jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/9be47f57a0c03aa56a06c5a14777b4060c631476
Cr-Commit-Position: refs/heads/master@{#35615}
==========

[commit-bot: I haz the power, 2016-04-19 11:56:56]

Patchset 5 (id:??) landed as
https://crrev.com/9be47f57a0c03aa56a06c5a14777b4060c631476
Cr-Commit-Position: refs/heads/master@{#35615}