Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876363006: Fix a few strong mode errors in dart:html (Closed)

Created:
4 years, 8 months ago by Alan Knight
Modified:
4 years, 8 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reverted the move of fullscreenEnabled, causes duplicate definitions in dart2js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -260 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 30 chunks +86 lines, -171 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 24 chunks +36 lines, -54 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_CompositionEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DeviceOrientationEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +12 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MessageEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_MutationEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_StorageEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_TextEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_TouchEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_UIEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Alan Knight
TBR
4 years, 8 months ago (2016-04-13 20:36:24 UTC) #2
Jacob
lgtm
4 years, 8 months ago (2016-04-13 20:57:57 UTC) #3
Alan Knight
Committed patchset #1 (id:1) manually as 65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847 (presubmit successful).
4 years, 8 months ago (2016-04-13 21:41:17 UTC) #5
Alan Knight
4 years, 8 months ago (2016-04-13 22:13:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a718c8dac91a463c95f08c335d0174081e7d7d27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698