Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 1876363006: Fix a few strong mode errors in dart:html (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reverted the move of fullscreenEnabled, causes duplicate definitions in dart2js Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 399e90d93a89309d71cf8b6d51953efe036b1717..886ceb049e7b1886777978db79a931eb0953db4d 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -264,8 +264,8 @@ $!STREAM_GETTER_SIGNATURES
// declared to return `ElementList`. This provides all the static analysis
// benefit so there is no need for this class have a constrained type parameter.
//
-class _FrozenElementList extends ListBase
- implements ElementList, NodeListWrapper {
+class _FrozenElementList extends ListBase<Element>
+ implements ElementList<Element>, NodeListWrapper {
final List<Node> _nodeList;
$if JSINTEROP
@@ -316,7 +316,7 @@ $endif
//
// as the code below converts the Iterable[value] to a string multiple
// times. Maybe compute the string and set className here.
- _nodeList.forEach((e) => e.classes = value);
+ forEach((e) => e.classes = value);
}
CssRect get contentEdge => new _ContentCssListRect(this);
@@ -1333,7 +1333,7 @@ $endif
// Workaround for Safari bug. Was also previously Chrome bug 229142
// - URIs are not resolved in new doc.
- var base = _parseDocument.createElement('base');
+ BaseElement base = _parseDocument.createElement('base');
base.href = document.baseUri;
_parseDocument.head.append(base);
}

Powered by Google App Engine
This is Rietveld 408576698