Issue 1876313002: Fixed a fullscreen race condition on OSX

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1876313002: Fixed a fullscreen race condition on OSX (Closed)

Created:
4 years, 8 months ago by spqchan

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Fixed a fullscreen race condition on OSX Ensure that |windowDidExitFullscreen| gets called after the fullscreen transition is completed. Slightly speed up the animations on Yosemite. BUG=593419 Review URL: https://codereview.chromium.org/1813693003 Cr-Commit-Position: refs/heads/master@{#383381} (cherry picked from commit 38ac6be27a783853f6a8fec136d2f4d3235a34d6) Committed: https://chromium.googlesource.com/chromium/src/+/537895984fa99ea4939e7f810581d7f19c18c7a1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -36 lines)			Patch
M	chrome/browser/ui/cocoa/browser_window_controller.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	3 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h	View	2 chunks	+8 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm	View	8 chunks	+42 lines, -15 lines	0 comments	Download

Total messages: 2 (1 generated)

spqchan

4 years, 8 months ago (2016-04-11 22:53:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
537895984fa99ea4939e7f810581d7f19c18c7a1.