Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h

Issue 1876313002: Fixed a fullscreen race condition on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
diff --git a/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h b/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
index 332bd949267b62259868147efeac6f2a7b4727af..a92a1b7ccdd73dd3842b671d3d9f4c9de08d6345 100644
--- a/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
+++ b/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
@@ -7,7 +7,7 @@
#import <Cocoa/Cocoa.h>
-@class FramedBrowserWindow;
+@class BrowserWindowController;
// This class is responsible for managing the custom transition of a
// BrowserWindow from its normal state into an AppKit Fullscreen state
@@ -94,20 +94,17 @@
@interface BrowserWindowFullscreenTransition : NSObject
-// Designated initializers. |window| is the NSWindow that is going to be moved
-// into a fullscreen Space (virtual desktop), and resized to have the same size
-// as the screen. |window|'s root view must be layer backed.
-// initEnterWithWindow will create a BrowserWindowFullscreenTransition that
-// enters fullscreen. initExitWithWindow will create one that exits fullscreen,
-// using |frame| as the frame that |window| is going to transition into.
-- (instancetype)initEnterWithWindow:(FramedBrowserWindow*)window;
-- (instancetype)initExitWithWindow:(FramedBrowserWindow*)window
- frame:(NSRect)frame
- tabStripBackgroundView:(NSView*)view;
+// Designated initializers. |controller| is the BrowserWindowController of the
+// window that's going to be moved into a fullscreen Space.
+- (instancetype)initEnterWithController:(BrowserWindowController*)controller;
+- (instancetype)initExitWithController:(BrowserWindowController*)controller;
// Returns the windows to be used in the custom fullscreen transition.
- (NSArray*)customWindowsForFullScreenTransition;
+// Returns true if the fullscreen transition is completed.
+- (BOOL)isTransitionCompleted;
+
// This method begins animation for exit or enter fullscreen transition.
// In this method, the following happens:
// - Animates the snapshot to the expected final size of the window while

Powered by Google App Engine
This is Rietveld 408576698