Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3020)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 1876313002: Fixed a fullscreen race condition on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.h
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h
index 13bf692647c3732b57040a3296d9c92b4fbc48f0..86e9059819c0e83c4b1a111c7e2b1c202ed903d5 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.h
+++ b/chrome/browser/ui/cocoa/browser_window_controller.h
@@ -164,6 +164,11 @@ class Command;
// True if the toolbar needs to be hidden in fullscreen.
BOOL shouldHideFullscreenToolbar_;
+ // True if AppKit has finished exiting fullscreen before the exit animation
+ // is completed. This flag is used to ensure that |windowDidExitFullscreen|
+ // is called after the exit fullscreen animation is complete.
+ BOOL appKitDidExitFullscreen_;
+
// The size of the original (non-fullscreen) window. This is saved just
// before entering fullscreen mode and is only valid when |-isFullscreen|
// returns YES.
@@ -424,6 +429,9 @@ class Command;
// deprecated.
- (BOOL)isTabbedWindow;
+// Returns the size of the original (non-fullscreen) window.
+- (NSRect)savedRegularWindowFrame;
+
@end // @interface BrowserWindowController(WindowType)
// Fullscreen terminology:
@@ -566,6 +574,10 @@ class Command;
// Whether if the toolbar should be hidden in fullscreen.
- (BOOL)shouldHideFullscreenToolbar;
+// Called by BrowserWindowFullscreenTransition when the exit animation is
+// finished.
+- (void)exitFullscreenAnimationFinished;
+
// Resizes the fullscreen window to fit the screen it's currently on. Called by
// the PresentationModeController when there is a change in monitor placement or
// resolution.
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698