Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1875913002: Cleanup: Convert const char* kFoo to const char kFoo[]. (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, posciak+watch_chromium.org, nektar+watch_chromium.org, sievers+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, aboxhall+watch_chromium.org, jam, chasej+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, kalyank, mlamouri+watch-content_chromium.org, dtseng+watch_chromium.org, rickyz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, jsbell+idb_chromium.org, zork+watch_chromium.org, michaeln, wfh+watch_chromium.org, shuchen+watch_chromium.org, mcasas+watch_chromium.org, cmumford, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Convert const char* kFoo to const char kFoo[]. Or change them to const char* const kFoo. Committed: https://crrev.com/418c505c6cb2cf6aa5d2d2aee582e90541b54287 Cr-Commit-Position: refs/heads/master@{#386441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -110 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_android.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 3 chunks +33 lines, -31 lines 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_database.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/appcache/appcache_update_job.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gl_helper_benchmark.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_net_log_parameters.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/speech/audio_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/google_one_shot_remote_engine.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/streams/stream_context.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/time_zone_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/zygote_host/zygote_communication_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/appcache/web_application_cache_host_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/vaapi_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/origin_trials/trial_token.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/stun_field_trial.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/x/x11_atom_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/x/x11_atom_cache.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
4 years, 8 months ago (2016-04-11 18:10:10 UTC) #2
Avi (use Gerrit)
lgtm 👍
4 years, 8 months ago (2016-04-11 18:16:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875913002/1
4 years, 8 months ago (2016-04-11 18:22:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 19:39:28 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 19:41:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/418c505c6cb2cf6aa5d2d2aee582e90541b54287
Cr-Commit-Position: refs/heads/master@{#386441}

Powered by Google App Engine
This is Rietveld 408576698