Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Side by Side Diff: ui/gfx/x/x11_atom_cache.h

Issue 1875913002: Cleanup: Convert const char* kFoo to const char kFoo[]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/media/webrtc/stun_field_trial.cc ('k') | ui/gfx/x/x11_atom_cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GFX_X_X11_ATOM_CACHE_H_ 5 #ifndef UI_GFX_X_X11_ATOM_CACHE_H_
6 #define UI_GFX_X_X11_ATOM_CACHE_H_ 6 #define UI_GFX_X_X11_ATOM_CACHE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "ui/gfx/gfx_export.h" 12 #include "ui/gfx/gfx_export.h"
13 #include "ui/gfx/x/x11_types.h" 13 #include "ui/gfx/x/x11_types.h"
14 14
15 namespace ui { 15 namespace ui {
16 16
17 // Pre-caches all Atoms on first use to minimize roundtrips to the X11 17 // Pre-caches all Atoms on first use to minimize roundtrips to the X11
18 // server. By default, GetAtom() will CHECK() that atoms accessed through 18 // server. By default, GetAtom() will CHECK() that atoms accessed through
19 // GetAtom() were passed to the constructor, but this behaviour can be changed 19 // GetAtom() were passed to the constructor, but this behaviour can be changed
20 // with allow_uncached_atoms(). 20 // with allow_uncached_atoms().
21 class GFX_EXPORT X11AtomCache { 21 class GFX_EXPORT X11AtomCache {
22 public: 22 public:
23 // Preinterns the NULL terminated list of string |to_cache_ on |xdisplay|. 23 // Preinterns the NULL terminated list of string |to_cache| on |xdisplay|.
24 X11AtomCache(XDisplay* xdisplay, const char** to_cache); 24 X11AtomCache(XDisplay* xdisplay, const char* const* to_cache);
25 ~X11AtomCache(); 25 ~X11AtomCache();
26 26
27 // Returns the pre-interned Atom without having to go to the x server. 27 // Returns the pre-interned Atom without having to go to the x server.
28 XAtom GetAtom(const char*) const; 28 XAtom GetAtom(const char*) const;
29 29
30 // When an Atom isn't in the list of items we've cached, we should look it 30 // When an Atom isn't in the list of items we've cached, we should look it
31 // up, cache it locally, and then return the result. 31 // up, cache it locally, and then return the result.
32 void allow_uncached_atoms() { uncached_atoms_allowed_ = true; } 32 void allow_uncached_atoms() { uncached_atoms_allowed_ = true; }
33 33
34 private: 34 private:
35 XDisplay* xdisplay_; 35 XDisplay* xdisplay_;
36 36
37 bool uncached_atoms_allowed_; 37 bool uncached_atoms_allowed_;
38 38
39 mutable std::map<std::string, XAtom> cached_atoms_; 39 mutable std::map<std::string, XAtom> cached_atoms_;
40 40
41 DISALLOW_COPY_AND_ASSIGN(X11AtomCache); 41 DISALLOW_COPY_AND_ASSIGN(X11AtomCache);
42 }; 42 };
43 43
44 } // namespace ui 44 } // namespace ui
45 45
46 #endif // UI_GFX_X_X11_ATOM_CACHE_H_ 46 #endif // UI_GFX_X_X11_ATOM_CACHE_H_
OLDNEW
« no previous file with comments | « content/renderer/media/webrtc/stun_field_trial.cc ('k') | ui/gfx/x/x11_atom_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698