Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: content/browser/appcache/appcache_update_job.cc

Issue 1875913002: Cleanup: Convert const char* kFoo to const char kFoo[]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_database.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_update_job.cc
diff --git a/content/browser/appcache/appcache_update_job.cc b/content/browser/appcache/appcache_update_job.cc
index 7c922f868a7cd3c9974a7551f74fd6346829cc45..bc654a8801efd6fc14950532feb0379a80b3981e 100644
--- a/content/browser/appcache/appcache_update_job.cc
+++ b/content/browser/appcache/appcache_update_job.cc
@@ -612,7 +612,7 @@ void AppCacheUpdateJob::HandleManifestFetchCompleted(
update_type_ == UPGRADE_ATTEMPT) {
storage_->MakeGroupObsolete(group_, this, response_code); // async
} else {
- const char* kFormatString = "Manifest fetch failed (%d) %s";
+ const char kFormatString[] = "Manifest fetch failed (%d) %s";
std::string message = FormatUrlErrorMessage(
kFormatString, manifest_url_, fetcher->result(), response_code);
HandleCacheFailure(AppCacheErrorDetails(message,
@@ -672,7 +672,7 @@ void AppCacheUpdateJob::ContinueHandleManifestFetchCompleted(bool changed) {
PARSE_MANIFEST_ALLOWING_INTERCEPTS :
PARSE_MANIFEST_PER_STANDARD,
manifest)) {
- const char* kFormatString = "Failed to parse manifest %s";
+ const char kFormatString[] = "Failed to parse manifest %s";
const std::string message = base::StringPrintf(kFormatString,
manifest_url_.spec().c_str());
HandleCacheFailure(
@@ -761,7 +761,7 @@ void AppCacheUpdateJob::HandleUrlFetchCompleted(URLFetcher* fetcher) {
entry.set_response_size(fetcher->existing_entry().response_size());
inprogress_cache_->AddOrModifyEntry(url, entry);
} else {
- const char* kFormatString = "Resource fetch failed (%d) %s";
+ const char kFormatString[] = "Resource fetch failed (%d) %s";
std::string message = FormatUrlErrorMessage(
kFormatString, url, fetcher->result(), response_code);
ResultType result = fetcher->result();
@@ -875,7 +875,7 @@ void AppCacheUpdateJob::HandleMasterEntryFetchCompleted(
failed_master_entries_.insert(url);
- const char* kFormatString = "Manifest fetch failed (%d) %s";
+ const char kFormatString[] = "Manifest fetch failed (%d) %s";
std::string message = FormatUrlErrorMessage(
kFormatString, request->url(), fetcher->result(), response_code);
host_notifier.SendErrorNotifications(
@@ -950,7 +950,7 @@ void AppCacheUpdateJob::HandleManifestRefetchCompleted(
MANIFEST_ERROR,
GURL());
} else {
- const char* kFormatString = "Manifest re-fetch failed (%d) %s";
+ const char kFormatString[] = "Manifest re-fetch failed (%d) %s";
std::string message = FormatUrlErrorMessage(
kFormatString, manifest_url_, fetcher->result(), response_code);
HandleCacheFailure(AppCacheErrorDetails(message,
« no previous file with comments | « content/browser/appcache/appcache_database.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698