Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1874923002: Fix flakiness when disabling swap out timer in tests. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness when disabling swap out timer in tests. The swap out timer could still fire in tests that were trying to reset it, so use another approach that disables the timer ahead of time. BUG=600957, 554825 TEST=Tests stay green. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/ecf91fe4382775df7e1be7f237ca5a767d2e9df1 Cr-Commit-Position: refs/heads/master@{#386429}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 4 chunks +10 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 3 chunks +3 lines, -12 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Charlie Reis
Alex, can you take a look? This will hopefully fix these tests on the slow ...
4 years, 8 months ago (2016-04-11 16:23:56 UTC) #3
alexmos
Nice, LGTM.
4 years, 8 months ago (2016-04-11 16:44:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874923002/20001
4 years, 8 months ago (2016-04-11 16:47:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 18:49:16 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 18:50:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ecf91fe4382775df7e1be7f237ca5a767d2e9df1
Cr-Commit-Position: refs/heads/master@{#386429}

Powered by Google App Engine
This is Rietveld 408576698