Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1874923002: Fix flakiness when disabling swap out timer in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 8e5046c893be33cc63e90a4ee5164bb8bbe817ec..3292e3a950ea823af14a04e756e1f9ae0ceea565 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -751,7 +751,7 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
// Allows tests to disable the swapout event timer to simulate bugs that
// happen before it fires (to avoid flakiness).
- void ResetSwapOutTimerForTesting();
+ void DisableSwapOutTimerForTesting();
// For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
// refcount that calls Shutdown when it reaches zero. This allows each
@@ -884,7 +884,7 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,
// Used to swap out or shut down this RFH when the unload event is taking too
// long to execute, depending on the number of active frames in the
- // SiteInstance.
+ // SiteInstance. May be null in tests.
std::unique_ptr<TimeoutMonitor> swapout_event_monitor_timeout_;
std::unique_ptr<ServiceRegistryImpl> service_registry_;
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698