Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1874923002: Fix flakiness when disabling swap out timer in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
744 // FrameTreeNode that is not a child of this node. 744 // FrameTreeNode that is not a child of this node.
745 FrameTreeNode* FindAndVerifyChild(int32_t child_frame_routing_id, 745 FrameTreeNode* FindAndVerifyChild(int32_t child_frame_routing_id,
746 bad_message::BadMessageReason reason); 746 bad_message::BadMessageReason reason);
747 747
748 // Creates a Web Bluetooth Service owned by the frame. 748 // Creates a Web Bluetooth Service owned by the frame.
749 void CreateWebBluetoothService( 749 void CreateWebBluetoothService(
750 mojo::InterfaceRequest<blink::mojom::WebBluetoothService> request); 750 mojo::InterfaceRequest<blink::mojom::WebBluetoothService> request);
751 751
752 // Allows tests to disable the swapout event timer to simulate bugs that 752 // Allows tests to disable the swapout event timer to simulate bugs that
753 // happen before it fires (to avoid flakiness). 753 // happen before it fires (to avoid flakiness).
754 void ResetSwapOutTimerForTesting(); 754 void DisableSwapOutTimerForTesting();
755 755
756 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a 756 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
757 // refcount that calls Shutdown when it reaches zero. This allows each 757 // refcount that calls Shutdown when it reaches zero. This allows each
758 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring 758 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
759 // we have a RenderViewHost for each RenderFrameHost. 759 // we have a RenderViewHost for each RenderFrameHost.
760 // TODO(creis): RenderViewHost will eventually go away and be replaced with 760 // TODO(creis): RenderViewHost will eventually go away and be replaced with
761 // some form of page context. 761 // some form of page context.
762 RenderViewHostImpl* render_view_host_; 762 RenderViewHostImpl* render_view_host_;
763 763
764 RenderFrameHostDelegate* delegate_; 764 RenderFrameHostDelegate* delegate_;
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
877 877
878 // The unique ID of the latest NavigationEntry that this RenderFrameHost is 878 // The unique ID of the latest NavigationEntry that this RenderFrameHost is
879 // showing. This may change even when this frame hasn't committed a page, 879 // showing. This may change even when this frame hasn't committed a page,
880 // such as for a new subframe navigation in a different frame. Tracking this 880 // such as for a new subframe navigation in a different frame. Tracking this
881 // allows us to send things like title and state updates to the latest 881 // allows us to send things like title and state updates to the latest
882 // relevant NavigationEntry. 882 // relevant NavigationEntry.
883 int nav_entry_id_; 883 int nav_entry_id_;
884 884
885 // Used to swap out or shut down this RFH when the unload event is taking too 885 // Used to swap out or shut down this RFH when the unload event is taking too
886 // long to execute, depending on the number of active frames in the 886 // long to execute, depending on the number of active frames in the
887 // SiteInstance. 887 // SiteInstance. May be null in tests.
888 std::unique_ptr<TimeoutMonitor> swapout_event_monitor_timeout_; 888 std::unique_ptr<TimeoutMonitor> swapout_event_monitor_timeout_;
889 889
890 std::unique_ptr<ServiceRegistryImpl> service_registry_; 890 std::unique_ptr<ServiceRegistryImpl> service_registry_;
891 891
892 #if defined(OS_ANDROID) 892 #if defined(OS_ANDROID)
893 std::unique_ptr<ServiceRegistryAndroid> service_registry_android_; 893 std::unique_ptr<ServiceRegistryAndroid> service_registry_android_;
894 #endif 894 #endif
895 895
896 std::unique_ptr<WebBluetoothServiceImpl> web_bluetooth_service_; 896 std::unique_ptr<WebBluetoothServiceImpl> web_bluetooth_service_;
897 897
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 970
971 // NOTE: This must be the last member. 971 // NOTE: This must be the last member.
972 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 972 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
973 973
974 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 974 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
975 }; 975 };
976 976
977 } // namespace content 977 } // namespace content
978 978
979 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 979 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698