ios/web/web_state/ui/crw_web_controller+protected.h - Issue 1874903003: Reversed WebState <-> CRWWebController ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller+protected.h

Issue 1874903003: Reversed WebState <-> CRWWebController ownership. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller+protected.h

diff --git a/ios/web/web_state/ui/crw_web_controller+protected.h b/ios/web/web_state/ui/crw_web_controller+protected.h

index 176235884b8aa249bdd3b582a840c0b89faab24b..79a91940818be95fe6903f4e75c9e2c895c138e1 100644

--- a/ios/web/web_state/ui/crw_web_controller+protected.h

+++ b/ios/web/web_state/ui/crw_web_controller+protected.h

@@ -106,8 +106,8 @@ static NSString* const kScriptImmediateName = @"crwebinvokeimmediate";

- (CRWWebControllerPendingNavigationInfo*)pendingNavigationInfo;

-// Designated initializer.

-- (instancetype)initWithWebState:(std::unique_ptr<web::WebStateImpl>)webState;

+// Designated initializer. Initializes web controller with unowned |webState|.

kkhorimoto 2016/04/12 21:36:13 "Initializes a web controller owned by |webState|"

Eugene But (OOO till 7-30) 2016/04/13 02:51:26 Owner of WC should not be mentioned here (see my o

Eugene But (OOO till 7-30) 2016/04/13 13:57:57 Updated the comments according to Rohit's suggesti

+- (instancetype)initWithWebState:(web::WebStateImpl*)webState;

// Creates a web view if it's not yet created.

- (void)ensureWebViewCreated;