Reversed WebState <-> CRWWebController ownership.

ios/web/web_state/ui/crw_web_controller+protected.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_WEB_STATE_UI_CRW_WEB_CONTROLLER_PROTECTED_H_
 #define IOS_WEB_WEB_STATE_UI_CRW_WEB_CONTROLLER_PROTECTED_H_
 
 #import "ios/web/web_state/ui/crw_web_controller.h"
 
 #import <WebKit/WebKit.h>
@@ skipping 88 matching lines @@
 
 // A set of script managers whose scripts have been injected into the current
 // page.
 @property(nonatomic, readonly) NSMutableSet* injectedScriptManagers;
 
 // Downloader for PassKit files. Lazy initialized.
 @property(nonatomic, readonly) CRWPassKitDownloader* passKitDownloader;
 
 - (CRWWebControllerPendingNavigationInfo*)pendingNavigationInfo;
 
-// Designated initializer.
-- (instancetype)initWithWebState:(std::unique_ptr<web::WebStateImpl>)webState;
+// Designated initializer. Initializes web controller with unowned |webState|.

[kkhorimoto, 2016/04/12 21:36:13]

"Initializes a web controller owned by |webState|"?

[Eugene But (OOO till 7-30), 2016/04/13 02:51:26]

Owner of WC should not be mentioned here (see my other comments, where I explain
why). But it is important to note that WC does not own |webState|.

[Eugene But (OOO till 7-30), 2016/04/13 13:57:57]

Updated the comments according to Rohit's suggestion.

+- (instancetype)initWithWebState:(web::WebStateImpl*)webState;
 
 // Creates a web view if it's not yet created.
 - (void)ensureWebViewCreated;
 
 // Destroys the web view by setting webView property to nil.
 - (void)resetWebView;
 
 // Returns the current URL of the web view, and sets |trustLevel| accordingly
 // based on the confidence in the verification.
 - (GURL)webURLWithTrustLevel:(web::URLVerificationTrustLevel*)trustLevel;
@@ skipping 295 matching lines @@
 
 // Converts MIME type string to WebViewDocumentType.
 - (web::WebViewDocumentType)documentTypeFromMIMEType:(NSString*)MIMEType;
 
 // Extracts Referer value from WKNavigationAction request header.
 - (NSString*)refererFromNavigationAction:(WKNavigationAction*)action;
 
 @end
 
 #endif  // IOS_WEB_WEB_STATE_UI_CRW_WEB_CONTROLLER_PROTECTED_H_